fix(postgresql): Add quotes for CamelCase columns#1729
Merged
kyleconroy merged 1 commit intosqlc-dev:mainfrom Jul 10, 2022
Merged
fix(postgresql): Add quotes for CamelCase columns#1729kyleconroy merged 1 commit intosqlc-dev:mainfrom
kyleconroy merged 1 commit intosqlc-dev:mainfrom
Conversation
If columns are created with CamelCase, they have to be quoted or else postgres won't find them.
gurleensethi
reviewed
Jul 9, 2022
| if c.conf.Engine == config.EnginePostgreSQL { | ||
| // camelCase means the column is also camelCase | ||
| if strings.ToLower(ident) != ident { | ||
| return "\"" + ident + "\"" |
There was a problem hiding this comment.
🎉 This will solve the problem where columns are in camel case and should not break anything.
|
@kyleconroy Can we release a new version of SQLC that contains this functionality? |
jlisthood
pushed a commit
to jlisthood/sqlc
that referenced
this pull request
Apr 28, 2023
If columns are created with CamelCase, they have to be quoted or else postgres won't find them.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If columns are created with CamelCase, they have to be quoted or else
postgres won't find them.
This PR only applies to
SELECT * FROM tablenamequeries. When the column names are specified individually with quotes, it already works.fixes #1718