fix: Let column names not invalidate Go field names#1840
Closed
rollulus wants to merge 1 commit intosqlc-dev:mainfrom
Closed
fix: Let column names not invalidate Go field names#1840rollulus wants to merge 1 commit intosqlc-dev:mainfrom
rollulus wants to merge 1 commit intosqlc-dev:mainfrom
Conversation
Contributor
Author
|
I wasn't sure about the e2e test naming convention. Also: thanks for this project! |
rollulus
force-pushed
the
fix/field-names
branch
2 times, most recently
from
74f5523 to
629913d
Compare
Column names are less restricted than Go struct field names, which should be proper Go identifiers. Hence, column names cannot be translated directly into field names. This commit tries to address this. Characters in column names that do not qualify as a Go identifier are stripped. The title casing as applied to underscores is applied to stripped characters.
rollulus
force-pushed
the
fix/field-names
branch
from
629913d to
d5aa1c5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Column names are less restricted than Go struct field names, which should be proper Go identifiers. Hence, column names cannot be translated directly into field names. This commit tries to address this.
Characters in column names that do not qualify as a Go identifier are stripped. The title casing as applied to underscores is applied to stripped characters.