feat: Allow use of table and column aliases for table functions returning unknown types#2156
Merged
kyleconroy merged 2 commits intosqlc-dev:mainfrom Jun 9, 2023
Merged
Conversation
Contributor
|
I really appreciate your continued work on this area, as you appear to be fixing our biggest pain points! This and your work on #1884 are much appreciated, and I hope both can get reviewed and merged soon! |
Contributor
Author
|
Thanks @StevenACoffman, I'm glad this is helpful! |
9d48aa8 to
9f172ce
Compare
9f172ce to
c7a10a7
Compare
…ning unknown types Signed-off-by: Andrew Haines <andrew@haines.org.nz>
c7a10a7 to
7234229
Compare
alfonsodev
pushed a commit
to ExponentiaTeam/sqlc
that referenced
this pull request
Oct 13, 2025
…ning unknown types (sqlc-dev#2156) Signed-off-by: Andrew Haines <andrew@haines.org.nz> Co-authored-by: Kyle Conroy <kyle@conroy.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
At the moment, when a table function returns a type that isn't a known table, it's excluded from the output columns completely. This makes it impossible to use
unnest()orunnest() WITH ORDINALITYwith a table alias (#1205, #1596).This PR allows constructs such as
and
I haven't attempted to solve this problem in general - it will only work for a table alias with column alias(es), and data types are
any, necessitating casts. This seems like a good first step, at least.Fixes #1205