Skip to content

fix missing unsigned param#2522

Merged
kyleconroy merged 3 commits intosqlc-dev:mainfrom
hiroebe:fix-missing-unsigned
Jul 25, 2023
Merged

fix missing unsigned param#2522
kyleconroy merged 3 commits intosqlc-dev:mainfrom
hiroebe:fix-missing-unsigned

Conversation

@hiroebe
Copy link
Contributor

@hiroebe hiroebe commented Jul 25, 2023

Fixes #2432

@kyleconroy
Copy link
Collaborator

kyleconroy commented Jul 25, 2023

@hiroebe Thanks for the fix. Could I ask you to add a new end-to-end test that includes the examples from #2432?

To do this, create a new directory inside the internal/endtoend/testdata directory named unsigned_params. In that directory copy the sqlc.json and query.sql files from the issue and generate new output using your fix.

Thanks!

@hiroebe
Copy link
Contributor Author

hiroebe commented Jul 25, 2023

@kyleconroy Thanks for the instruction. I've added a new end-to-end test.
I didn't copy the schema and queries as it is in the issue but added a smaller example. That small one should be enough to reproduce the bug being fixed, but let me know if you think the original example in the issue is more suitable.

hiroebe
hiroebe commented Jul 25, 2023
View reviewed changes
internal/endtoend/testdata/unsigned_params/mysql/go/query.sql.go
INSERT INTO foo (id) VALUES (?)
`

func (q *Queries) CreateFoo(ctx context.Context, id uint32) error {
Copy link
Contributor Author

@hiroebe hiroebe Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: The id parameter was previously generated as int32 while it's unsigned in MySQL schema.

Copy link
Collaborator

@kyleconroy kyleconroy Jul 25, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this will be a breaking change, but it's necessary, as the existing code can lead to overflow errors.

@kyleconroy kyleconroy merged commit e3c657d into sqlc-dev:main Jul 25, 2023
@hiroebe hiroebe deleted the fix-missing-unsigned branch July 25, 2023 16:29
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
@hiroebe
fix(mysql)!: Generate unsigned param (sqlc-dev#2522)
a73ec20 
A fix to the original change (sqlc-dev#1746) that added support for unsigned integers. While this is a breaking change, it's impact should be smaller than the previous change.

* fix missing unsigned param
* add end-to-end test for unsigned_params
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kyleconroy kyleconroy kyleconroy left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Unsigned types not present in query parameters

2 participants

@hiroebe @kyleconroy