internal/dinosql: ignore golang-migrate rollbacks#320
Merged
kyleconroy merged 1 commit intosqlc-dev:masterfrom Feb 6, 2020
Merged
internal/dinosql: ignore golang-migrate rollbacks#320kyleconroy merged 1 commit intosqlc-dev:masterfrom
kyleconroy merged 1 commit intosqlc-dev:masterfrom
Conversation
Collaborator
|
@treuherz Thanks! Especially for the tests |
Contributor
Author
|
Happy to contribute, thanks for the speedy merge! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We use golang-migrate for migration management, and would like to be able to use it with sqlc. The obstacle here is that it doesn't indicate up/down migrations through special comments, but by naming the SQL files things like
so I've had to put the check in
ReadSQLFilesand test the functionality differently.Let me know if you'd like any of this done differently, I'm happy to keep tweaking it.