Use API to check Tor connection #5910
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
there is no check for invalid JSON: |
stamparm
added a commit
that referenced
this pull request
Jun 16, 2025
tanaydin
pushed a commit
to tanaydin/sqlmap
that referenced
this pull request
Jul 14, 2025
tanaydin
pushed a commit
to tanaydin/sqlmap
that referenced
this pull request
Jul 14, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the way the sqlmap checks the Tor connection.
Currently, https://check.torproject.org/ is fetched and checked, whether it contains
Congratulations.With this PR, https://check.torproject.org/api/ip is used instead, because I think using a JSON API is much cleaner, more reliable / stable and consumes less data.
The
--check-torhas been first implemented in 86b4a35, before the JSON API (https://gitlab.torproject.org/tpo/network-health/metrics/tor-check/-/commit/727327d4f1f3ecd5209f5ea2e827676019c56459) has been added to check.torproject.org.