Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #311 +/- ##
==========================================
- Coverage 86.81% 82.66% -4.16%
==========================================
Files 16 16
Lines 986 992 +6
==========================================
- Hits 856 820 -36
- Misses 130 172 +42 |
dfed
commented
Apr 23, 2024
| func test_secureEnclaveSharedGroupValetsWithDifferingIdentifiers_canNotAccessSameData() throws | ||
| { | ||
| guard testEnvironmentIsSigned() && testEnvironmentSupportsWhenPasscodeSet() else { | ||
| guard testEnvironmentIsSignedOrDoesNotRequireEntitlement() && testEnvironmentSupportsWhenPasscodeSet() else { |
dfed
commented
Apr 23, 2024
.github/workflows/ci.yml
Outdated
Comment on lines
+20
to
+25
| 'iOS_14,tvOS_14,watchOS_7', | ||
| 'iOS_13,tvOS_13,watchOS_6', | ||
| 'iOS_14', | ||
| 'tvOS_14', | ||
| 'watchOS_7', | ||
| 'iOS_13', | ||
| 'tvOS_13', | ||
| 'watchOS_6', |
Collaborator
Author
There was a problem hiding this comment.
split this out for faster iteration because we have the machines
* Actually fail CI when tests fail * Throw when we encounter errors * Remove builds with Xcode that do not support Swift Concurrency * Use appropriate Xcode for the job * More tests require signed environments now * Fix macOS 14 test sdk * Use correct simulator name * Do not embed watchOS * Massage compiler * Remove unnecessary Valet watchOS Test Host App.app * New watch host target * simpler * stop testing watchOS_8 * Xcode 13 or later
dfed
commented
Apr 23, 2024
| ## Requirements | ||
|
|
||
| * Xcode 12.5 or later. | ||
| * Xcode 13.0 or later. |
Collaborator
Author
There was a problem hiding this comment.
Follow-up to #308 now that CI is working.
dfed
commented
Apr 23, 2024
Comment on lines
-1
to
-3
| [submodule "Tests/xctest-watchOS"] | ||
| path = Tests/XCTest-watchOS | ||
| url = https://github.com/dfed/XCTest-watchOS.git |
Collaborator
Author
|
This is not an API change - it only affects CI. Merging pre-review to get CI working again + adding watch coverage. Happy to address feedback post-merge. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #128.
We don't have coverage for all watchOS versions, but it's better than what we had.
A good amount of work is from #312 and #313 – it's worth reviewing my comments there.