3.0 Development Branch by EricMuller22 · Pull Request #80 · square/Valet

EricMuller22 · 2016-06-16T00:32:12Z

The one where emuller flails around making things Schwifty

danielribeiro · 2016-06-18T07:48:09Z

xcodebuild: error: The project named "Valet" does not contain a scheme named "Valet Mac". The "-list" option can be used to find the names of the schemes in the project.

Maybe forgot to mark as a shared scheme?

dfed · 2016-09-28T23:27:51Z

.travis.yml

@@ -1,10 +1,9 @@
 language: objective-c
-osx_image: xcode6.4
+osx_image: xcode7.3


since we're going to be using Swift 3, we'll need to go to xcode8

dfed · 2016-09-28T23:28:29Z

Gemfile

 source 'https://rubygems.org'

-gem 'cocoapods', '0.39.0'
+gem 'cocoapods', '1.0.1'


you'll need 1.1.0.rc.2 at a minimum to support Swift 3

dfed · 2017-09-16T19:12:08Z

After a way-too-long hiatus, Eric and I are back and working on this PR. There's a lot to do, but we're starting with getting our Swift Valet tests up and running on Xcode 9 GM Seed using Swift 3.2. Once we're building with Swift 3.2, we'll likely change the tests to Swift 4.

Our high-level plan is still the same as we outlined in #84.

EricMuller22 · 2017-09-19T00:57:34Z

Valet/SynchronizableAccessibility.swift

+import Foundation
+
+
+public enum SynchronizableAccessibility: CustomStringConvertible {


possible to protocolize instead?

also, possibly better spot (maybe not): internal enums to the two classes where we can only expose a subset like this? (synchronizable, secureenclave)

EricMuller22 · 2017-09-19T00:59:04Z

Valet/SynchronizableValet.swift

+import Foundation
+
+
+@available(iOS 7.0.3, macOS 10.9, *)


EricMuller22 · 2017-09-19T00:59:17Z

Valet/SynchronizableValet.swift

+
+
+@available(iOS 7.0.3, macOS 10.9, *)
+/// Reads and writes keychain elements that are synchronized with iCloud (supported on devices on iOS 7.0.3 and later).


comment also outdated 😂

EricMuller22 · 2017-09-19T01:01:21Z

Valet/SynchronizableValet.swift

+
+@available(iOS 7.0.3, macOS 10.9, *)
+/// Reads and writes keychain elements that are synchronized with iCloud (supported on devices on iOS 7.0.3 and later).
+public final class SynchronizableValet: NSObject, KeychainQueryConvertible {


devil's advocate - could we de-duplicate some of this?

now that we've done this, subclass feels more valid. or.... base Valet but with a different flavor/accessibility

EricMuller22 · 2017-09-19T01:04:14Z

ValetTests/SynchronizableTests.swift

-// The iPhone simulator fakes entitlements, allowing us to test the iCloud Keychain (VALSynchronizableValet) code without writing a signed host app.
-#if (arch(i386) || arch(x86_64)) && os(iOS)
+// Until we can write a signed host app on macOS, we can only test the iCloud Keychain (SynchronizableValet) code on iOS.
+#if os(iOS)


I'm a bit nervous about removal of the simulator #if logic here - e.g. I think unit tests can be run on device and these will fail unless the build is signed

dfed · 2017-10-03T00:02:52Z

Tests/ValetTests.swift

+        }
+    }
+
+    class func iCloudPermutations(_ identifier: Identifier, shared: Bool = false) -> [Valet] {


would use with identifier rather than just _ identifier. Unnamed vars confuse me

dfed · 2017-10-03T00:03:12Z

Tests/SynchronizableTests.swift

        valet.removeAllObjects()
+        let identifier = SynchronizableTests.identifier
+        let allPermutations = Valet.iCloudPermutations(identifier) + Valet.iCloudPermutations(identifier, shared: true)
+        _ = allPermutations.map { testValet in testValet.removeAllObjects() }


you're looking for forEach

…und a bug :)

…values

gfontenot · 2018-03-03T02:28:58Z

🎉 ✨ 🕺

AndrewSB · 2018-03-03T02:46:23Z

🎈🎉🔒

EricMuller22 force-pushed the develop/3.0 branch from 2801566 to 4d75109 Compare June 16, 2016 01:28

EricMuller22 force-pushed the develop/3.0 branch from 1482857 to 82f5a6e Compare June 20, 2016 20:31

dfed reviewed Sep 28, 2016

View reviewed changes

EricMuller22 force-pushed the develop/3.0 branch 3 times, most recently from 7586397 to a08298f Compare September 17, 2017 22:18

dfed force-pushed the develop/3.0 branch 4 times, most recently from 522b3e1 to bf651bc Compare September 18, 2017 16:09

EricMuller22 commented Sep 19, 2017

View reviewed changes

Valet/SynchronizableValet.swift Outdated

import Foundation

@available(iOS 7.0.3, macOS 10.9, *)

Copy link
Copy Markdown

Collaborator Author

EricMuller22 Sep 19, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💀

EricMuller22 commented Sep 19, 2017

View reviewed changes

dfed mentioned this pull request Sep 19, 2017

Enable allKeys and removeAllObjects methods on VALSinglePromptSecureEnclaveValet #108

Closed

dfed force-pushed the develop/3.0 branch from 4c17f15 to cc070e8 Compare September 19, 2017 21:30

This was referenced Sep 19, 2017

Swift package manager support #89

Closed

Missing Entitlements in debugger? #60

Closed

dfed mentioned this pull request Sep 27, 2017

FIX [VALSinglePromptSecureEnclaveValet containsObjectForKey] on TouchID fingerprints changes #116

Merged

EricMuller22 force-pushed the develop/3.0 branch from a5c41ca to 3bc4eb7 Compare October 1, 2017 21:23

dfed force-pushed the develop/3.0 branch 3 times, most recently from 6e4396a to 9d359e9 Compare October 1, 2017 21:49

EricMuller22 force-pushed the develop/3.0 branch from 7ca2678 to d233d39 Compare October 2, 2017 01:31

dfed reviewed Oct 3, 2017

View reviewed changes

dfed and others added 24 commits March 2, 2018 17:30

Update README

777de42

Remove Objective-C test file (after using it to check API surface)

6acacae

Better coverage for canAccessKeychain and backwards compatibility. Fo…

5163a7e

…und a bug :)

More README changes

5a7c459

Refactor 'permutations' tests a bit

aa29435

Use emoji at beginning of Objective-C Compatibility methods

cefe257

address feedback re: testing nit

52e9ab7

Update README for Face ID

7b458b9

'for key: Key' -> 'forKey key: String'

e54f35b

SecureEnclaveSinglePromptValet -> SinglePromptSecureEnclaveValet

bad3e00

README - migration from Valet 2

1a036fc

Remove Flavors entirely

781eea2

Unify on Swift 4.0 (this was all over the place in the .xcodeproj)

f1e5e75

NickEntin feedback

581d191

Increase timeout on test_concurrentSetAndRemoveOperations

f7a2b80

NickEntin feedback, part 2

db34ece

Simplify SecureEnclave.Result == using a single switch over multiple …

e54733c

…values

Consolidate switch statement

e088f7c

Fix objc README samples

6ee0383

OS X -> macOS

d96ff5a

Make init() initializers unavailable rather than deprecated

2952d8b

README clarifications around reading/writing between Valets

74b2e3f

Make init() override initializers private

0d4e281

Fix Contributing.md formatting

546ddd6

dfed force-pushed the develop/3.0 branch from 001881c to 546ddd6 Compare March 3, 2018 01:35

dfed merged commit acab210 into master Mar 3, 2018

dfed deleted the develop/3.0 branch March 3, 2018 02:19

dfed mentioned this pull request Dec 26, 2019

[Valet 4.0] Convert APIs to throw rather than return booleans or enums #198

Merged

		import Foundation


		public enum SynchronizableAccessibility: CustomStringConvertible {



		@available(iOS 7.0.3, macOS 10.9, *)
		/// Reads and writes keychain elements that are synchronized with iCloud (supported on devices on iOS 7.0.3 and later).

Conversation

EricMuller22 commented Jun 16, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

danielribeiro commented Jun 18, 2016

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dfed commented Sep 16, 2017

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

gfontenot commented Mar 3, 2018

Uh oh!

AndrewSB commented Mar 3, 2018

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

EricMuller22 commented Jun 16, 2016 •

edited

Loading