Bump s3fs lower bound to >=2024.2.0#39
Closed
nkpart wants to merge 1 commit intosquare:masterfrom
Closed
Conversation
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
The s3fs dependency had no version floor, allowing the resolver to pull ancient versions (e.g. 0.4.2) in downstream consumers. Add a lower bound of 2024.2.0 to ensure a modern version is resolved. Bump package version to 0.9.5. Co-authored-by: Amp <amp@ampcode.com> Amp-Thread-ID: https://ampcode.com/threads/T-019d8442-4ab4-700d-8f8f-fed010bf9c75
nkpart
force-pushed
the
npartridge.bump-s3fs-lower-bound
branch
from
e8b22e4 to
06edd0a
Compare
Author
|
Closing — s3fs is not directly imported anywhere in the blocks codebase. The dependency was added in 0.9.4 but appears to be unnecessary. Downstream consumers can constrain it away or use 0.9.3 which doesn't include it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The s3fs dependency had no version floor, allowing resolvers to pull ancient versions (e.g. 0.4.2) in downstream consumers. This adds a lower bound of 2024.2.0 to ensure a modern version is resolved.
Bump package version to 0.9.5.