Skip to content

Conversation

@BrianIp
Copy link
Contributor

@BrianIp BrianIp commented Feb 10, 2016

@postster
Copy link
Contributor

LGTM

select 'bigint unsigned' as proper_type, 18446744073709551615 as max_size
) maxes ON (proper_type = CONCAT(LEFT(column_type, GREATEST(0, LOCATE('(', column_type)-1)), RIGHT(column_type, LENGTH(column_type)-LOCATE(')', column_type))))
where
table_schema NOT IN ('common_schema', 'mysql', '_pending_drops')
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TODO (brianip): make these configurable

@michaelfinch
Copy link
Collaborator

lgtm

@bwester
Copy link
Member

bwester commented Dec 15, 2017

Hi, I just noticed this open PR. Is it still relevant?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants