Skip to content

Conversation

@bopopescu
Copy link

For diversity reasons, it would be nice to try to avoid 'master' and 'slave' terminology in this repository which can be associated to slavery. The master-slave terminology could be problematic for people in several countries which has the history of slavery like Romania, USA and many others. Thank you for considering the proposal. Let me know if any changes in the PR are needed, I would be happy to implement them.

@daniel-nichter
Copy link
Contributor

daniel-nichter commented Jul 31, 2020

Thanks for the PR @bopopescu. There are two issues that need to be addressed before we can merge this. First, MySQL's new official terminology is "source" and "replica":

Second, vars in the code that map directly to vars in MySQL output which haven't changed yet (e.g. Exec_Master_Log_Pos) need to remain the same else the code won't work.

If you can make these two changes, we'd be happy to merge this PR.

(Also re https://github.com/square/inspect/blob/master/CONTRIBUTING.md, have you signed the CLA?)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants