Merged
Conversation
This borrows from Gson's UnsafeAllocator. I didn't actually borrow much from Gson's reflective type adapter, but I'll need to review that in follow up to see if I forgot anything that Gson covers. Most interesting design decision here is that fields are serialized in alphabetical order. Also we're pretty nice around detecting field collisiosn and failing early.
swankjesse
force-pushed
the
jwilson_0322_classadapter
branch
from
9be0226 to
08becc1
Compare
Collaborator
There was a problem hiding this comment.
super minor nit: we'd normally call this 'ignored'
Collaborator
There was a problem hiding this comment.
i see the others now. interesting convention.
Collaborator
Author
There was a problem hiding this comment.
I think its probably a dumb convention ‘cause I still need the explanatory comment to prevent a warning.
Collaborator
|
CI is broken. Will fix tomorrow. LGTM |
swankjesse
added a commit
that referenced
this pull request
Mar 23, 2015
Big start into ClassAdapter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This borrows from Gson's UnsafeAllocator. I didn't actually
borrow much from Gson's reflective type adapter, but I'll need
to review that in follow up to see if I forgot anything that
Gson covers.
Most interesting design decision here is that fields are
serialized in alphabetical order. Also we're pretty nice
around detecting field collisiosn and failing early.