Test quirks of HostnameVerifier #6353
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
swankjesse
approved these changes
Oct 30, 2020
Collaborator
Author
|
The approval gives me nice warm fuzzies, but it's blocked to resolve what we think the behaviour should be. Or just assert the observed external behaviour since it is JSSE? |
Collaborator
|
Should reject these in Certifikit? Lets change it to always return false if we see any non-ASCII characters? They shouldn’t be in the certificate and therefore we shouldn’t match if they’re in the hostname arg. |
yschimke
commented
Oct 31, 2020
| * The RI does parse them, so the CN is unused. | ||
| */ | ||
| @Test @Ignore public void testWilcardNonAsciiSubjectAlt() throws Exception { | ||
| @Test public void testWilcardNonAsciiSubjectAlt() throws Exception { |
Collaborator
Author
There was a problem hiding this comment.
@swankjesse I reactivated these tests as part of the change, are you ok with these?
Collaborator
Author
@swankjesse I've landed with this change, overall probably worth a quick post review for style. |
swankjesse
reviewed
Oct 31, 2020
| * The RI does parse them, so the CN is unused. | ||
| */ | ||
| @Test @Ignore public void testWilcardNonAsciiSubjectAlt() throws Exception { | ||
| @Test public void testWilcardNonAsciiSubjectAlt() throws Exception { |
yschimke
added a commit
to yschimke/okhttp
that referenced
this pull request
Jul 4, 2021
* Test quirks of HostnameVerifier. * Restrict successful results to ascii input.
yschimke
added a commit
that referenced
this pull request
Jul 4, 2021
* Use generated certificates in unit tests (#6346) * Use generated certificates in unit tests * Strict to ascii lowercase implementation Co-authored-by: Jesse Wilson <jwilson@squareup.com> * More restrictive behaviour of OkHostnameVerifier (#6353) * Test quirks of HostnameVerifier. * Restrict successful results to ascii input. Co-authored-by: Jesse Wilson <jwilson@squareup.com>
This was referenced Jun 9, 2022
This was referenced Dec 12, 2024
This was referenced Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.