Fix: Handle multiple 1xx responses#8569
Merged
yschimke merged 1 commit intosquare:masterfrom Nov 5, 2024
Merged
Conversation
This change updates the client to handle multiple 10x (Processing etc) responses from the server. The client now waits for the final response with a status code other than 10x before proceeding. #fixes 8568
Collaborator
Author
|
cc @reschke |
yschimke
changed the title
JakeWharton
approved these changes
Nov 4, 2024
Contributor
|
LGTM; make sure it's 1xx, not 10x though. |
yschimke
added a commit
to yschimke/okhttp
that referenced
this pull request
May 5, 2025
This change updates the client to handle multiple 1xx (Processing etc) responses from the server. The client now waits for the final response with a status code other than 1xx before proceeding. From https://datatracker.ietf.org/doc/html/rfc7231#section-6.2 > A client MUST be able to parse one or more 1xx responses received prior to a final response, even if the client does not expect one. A user agent MAY ignore unexpected 1xx responses. fixes square#8568 (cherry picked from commit f1e6d01)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change updates the client to handle multiple 1xx (Processing etc) responses from the server. The client now waits for the final response with a status code other than 1xx before proceeding.
From https://datatracker.ietf.org/doc/html/rfc7231#section-6.2
fixes #8568