Added ACL for checking client's connection marks#108
Closed
k0rv1n wants to merge 1 commit intosquid-cache:masterfrom
Closed
Added ACL for checking client's connection marks#108k0rv1n wants to merge 1 commit intosquid-cache:masterfrom
k0rv1n wants to merge 1 commit intosquid-cache:masterfrom
Conversation
Collaborator
|
Can one of the admins verify this patch? |
k0rv1n
force-pushed
the
connmark_acl_2
branch
2 times, most recently
from
c905098 to
9a6279d
Compare
Contributor
|
OK to test |
k0rv1n
force-pushed
the
connmark_acl_2
branch
from
9a6279d to
7121389
Compare
yadij
requested changes
Dec 21, 2017
Contributor
yadij
left a comment
yadij
left a comment
There was a problem hiding this comment.
The code still uses a lot of tabs rather than spaces. Other than that just some documentation fixes.
| * Comm::TcpAcceptor::acceptOne | ||
| * | ||
| * @param server Server side descriptor of connection to get mark for | ||
| * @param clientFde Pointer to client side fde instance to set nfmarkFromServer in |
Contributor
There was a problem hiding this comment.
This parameter documentation is now incorrect and needs updating
| namespace Qos | ||
| { | ||
|
|
||
| enum Direction { |
yadij
added
the
S-waiting-for-author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworked #106.