Merged
Conversation
yadij
force-pushed
the
v5-cleanup_ip_memcpy
branch
from
f01d48e to
f521fd4
Compare
rousskov
reviewed
Jan 15, 2018
src/ip/Address.cc
Outdated
| Ip::Address::operator =(const Ip::Address &s) | ||
| { | ||
| memcpy(this, &s, sizeof(Ip::Address)); | ||
| memmove(&mSocketAddr_, &s.mSocketAddr_, sizeof(struct sockaddr_in6)); |
Contributor
There was a problem hiding this comment.
If the default generated assignment operator works, please use that instead (and check whether we can remove an explicit copy constructor as well).
Contributor
Author
|
Do you mean converting those two to their C++11 " = default;" definitions? |
Contributor
|
Yes, either that or removing them completely. If both solutions "work", pick whichever style you prefer for this use case (explicit =default or nothing explicit at all). |
yadij
force-pushed
the
v5-cleanup_ip_memcpy
branch
from
f521fd4 to
223d7d6
Compare
yadij
added
the
S-waiting-for-reviewer
rousskov
changed the title
rousskov
approved these changes
Jan 19, 2018
Contributor
rousskov
left a comment
rousskov
left a comment
There was a problem hiding this comment.
LGTM.
I polished the PR (and future commit) title and description to match the latest code version, to fix namespace spelling, and to disclaim knowledge of any specific bugs this fix addresses (AFAIK). Please feel free to polish further as needed and do not forget to use the updated title/description during the commit.
rousskov
added
S-waiting-for-committer
Most uses of memcpy should have been memove() to prevent potential copy-to-self bugs.
The default copy-construct and copy-assignment operators seem sufficient and under C++11 now seem to work.
yadij
force-pushed
the
v5-cleanup_ip_memcpy
branch
from
223d7d6 to
9b9da2e
Compare
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Feb 1, 2018
Explicit copy construction was slow and unnecessary. Explicit copy assignment mishandled self copying and was unnecessary. The remaining memcpy() calls mishandled self copying. There are no known cases of Ip::Address self copying.
yadij
added a commit
that referenced
this pull request
Feb 2, 2018
Explicit copy construction was slow and unnecessary. Explicit copy assignment mishandled self copying and was unnecessary. The remaining memcpy() calls mishandled self copying. There are no known cases of Ip::Address self copying.
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Jul 8, 2018
Explicit copy construction was slow and unnecessary. Explicit copy assignment mishandled self copying and was unnecessary. The remaining memcpy() calls mishandled self copying. There are no known cases of Ip::Address self copying.
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Jul 8, 2018
Explicit copy construction was slow and unnecessary. Explicit copy assignment mishandled self copying and was unnecessary. The remaining memcpy() calls mishandled self copying. There are no known cases of Ip::Address self copying.
yadij
added a commit
that referenced
this pull request
Jul 8, 2018
Explicit copy construction was slow and unnecessary. Explicit copy assignment mishandled self copying and was unnecessary. The remaining memcpy() calls mishandled self copying. There are no known cases of Ip::Address self copying.
rousskov
removed
the
S-waiting-for-committer
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explicit copy construction was slow and unnecessary.
Explicit copy assignment mishandled self copying and was unnecessary.
The remaining memcpy() calls mishandled self copying.
There are no known cases of Ip::Address self copying.