Conversation
Collaborator
|
Can one of the admins verify this patch? |
rousskov
approved these changes
Jan 19, 2018
Contributor
rousskov
left a comment
rousskov
left a comment
There was a problem hiding this comment.
LGTM. Minor grammar fixes and polishing suggestions inlined.
doc/release-notes/release-4.sgml
Outdated
|
|
||
| <sect1>ESI Custom Parser removal | ||
| <p>The Squid custom ESI parser has been removed in favour of better supported | ||
| and maintained third-party libraries. At least one of libxml2 or libexpat are |
Contributor
There was a problem hiding this comment.
s/are/is/ or, better, rephrase as "To enable ESI support, libxml2 or libexpat is now required." and spell out "(Edge Side Includes)" after the first mentioning of the term in this paragraph.
doc/release-notes/release-4.sgml
Outdated
|
|
||
| <tag>esi_parser</tag> | ||
| <p>Removed <em>custom</em> parser option. | ||
| <p>Changed default to auto-detect available parsers instead of a fixed default. |
Contributor
There was a problem hiding this comment.
s/a fixed default/using the custom parser/
doc/release-notes/release-4.sgml
Outdated
|
|
||
| <tag>--enable-esi</tag> | ||
| <p>Custom ESI parser has been removed. | ||
| Libxml2 or libexpat are now required to enable ESI processor. |
Contributor
There was a problem hiding this comment.
s/are/is/ or see a version mentioned earlier that does not require spelling libxml2 as Libxml2.
I would also s/processor/processing/.
squidadm
force-pushed
the
maintenance-5
branch
from
940aa36 to
8239574
Compare
Contributor
|
OK to test |
squidadm
added a commit
to squidadm/squid
that referenced
this pull request
Jan 19, 2018
yadij
pushed a commit
to yadij/squid
that referenced
this pull request
Jan 19, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.