Fixed store.cc "!mem_obj" assertion via peerDigestRequest#134
Merged
rousskov merged 2 commits intosquid-cache:masterfrom Jan 23, 2018
Merged
Conversation
Broken by commit 76d6111 which (correctly) made createMeObject() assert but missed one case where the old code should have been converted to call the new ensureMemObject() instead. peerDigestRequest() is called every 5 minutes, triggered by the peerDigestCheck event. Most calls find the old digest entry that has the same method and URIs.
Contributor
Author
|
I have not tested the proposed fix but am asking @chtsanti (who found the bug) to review and test it. |
chtsanti
approved these changes
Jan 23, 2018
Contributor
eduard-bagdasaryan
left a comment
eduard-bagdasaryan
left a comment
There was a problem hiding this comment.
Not actual now (already merged), but this trivial fix looks correct to me.
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Feb 1, 2018
…e#134) Broken by commit 76d6111 which (correctly) made createMeObject() assert but missed one case where the old code should have been converted to call the new ensureMemObject() instead. peerDigestRequest() is called every 5 minutes, triggered by the peerDigestCheck event. Most calls find the old digest entry that has the same method and URIs.
yadij
pushed a commit
that referenced
this pull request
Feb 2, 2018
Broken by commit 76d6111 which (correctly) made createMeObject() assert but missed one case where the old code should have been converted to call the new ensureMemObject() instead. peerDigestRequest() is called every 5 minutes, triggered by the peerDigestCheck event. Most calls find the old digest entry that has the same method and URIs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Broken by commit 76d6111 (GitHub PR #50) which (correctly) made
createMeObject() assert but missed one case where the old code should
have been converted to call the new ensureMemObject() instead.
peerDigestRequest() is called every 5 minutes, triggered by the
peerDigestCheck event. Most calls find the old digest entry that has the
same method and URIs.