Fixed localnet ACL definition in recommended/default squid.conf#146
Merged
rousskov merged 1 commit intosquid-cache:masterfrom Feb 9, 2018
xeron:fix-localhet-typo
Merged
Fixed localnet ACL definition in recommended/default squid.conf#146rousskov merged 1 commit intosquid-cache:masterfrom xeron:fix-localhet-typo
rousskov merged 1 commit intosquid-cache:masterfrom
xeron:fix-localhet-typo
Conversation
Collaborator
|
Can one of the admins verify this patch? |
yadij
approved these changes
Feb 9, 2018
Contributor
|
OK to test |
rousskov
changed the title
Contributor
|
I merged with a more detailed description. It was not just a benign documentation typo -- the typo affected access controls in Squid default (and recommended "minimum") configurations. Good catch! |
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Feb 12, 2018
…d-cache#146) ... it was lacking 169.254.0.0/16 subnet due to a typo in fe204e1.
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Feb 12, 2018
…d-cache#146) ... it was lacking 169.254.0.0/16 subnet due to a typo in fe204e1.
yadij
pushed a commit
that referenced
this pull request
Feb 13, 2018
... it was lacking 169.254.0.0/16 subnet due to a typo in fe204e1.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
... it was lacking 169.254.0.0/16 subnet due to a typo in fe204e1.