Bump minimum required GnuTLS version to 3.4.0#156
Merged
yadij merged 2 commits intosquid-cache:masterfrom Feb 26, 2018
Merged
Conversation
squid-anubis
added
the
M-failed-description
Contributor
Author
|
@rousskov, FYI: The recent changes to build node results occurs because CentOS 7 recently gained an upgrade from 3.1 to 3.3 GnuTLS and pkg-config support in the process. So it was not previously building GnuTLS at all, but now can and reveals the version discrepancy. |
yadij
added
the
S-waiting-for-reviewer
yadij
force-pushed
the
v5-gnutls-version-bump
branch
from
28a908f to
26e5ad6
Compare
PR#81 added functions only provided by GnuTLS 3.4.0 and later, but did not bump the configure.ac check for GnuTLS to enforce that version as minimum.
yadij
force-pushed
the
v5-gnutls-version-bump
branch
from
26e5ad6 to
40859ee
Compare
Contributor
|
FYI: GitHub did not tell me about this PR until you requested review. I do not know why. It usually notifies about all new PRs. |
rousskov
changed the title
squid-anubis
removed
the
M-failed-description
rousskov
approved these changes
Feb 25, 2018
Contributor
rousskov
left a comment
rousskov
left a comment
There was a problem hiding this comment.
LGTM if you do not want to support earlier GnuTLS versions.
rousskov
added
S-waiting-for-committer
Contributor
And it will stop building GnuTLS again after this PR is committed, right? Do we have any Jenkins nodes with GnuTLS v3.4 or later? |
Contributor
Author
|
Yes CentOS will stop building with GunuTLS again. Pretty much all OS not derived from RHEL provide newer GnuTLS versions. |
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
pushed a commit
that referenced
this pull request
Feb 26, 2018
squid-anubis
added
M-failed-other
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Feb 26, 2018
PR#81 added functions only provided by GnuTLS 3.4.0 and later, but did not bump the configure.ac check for GnuTLS to enforce that version as minimum.
yadij
added a commit
that referenced
this pull request
Feb 26, 2018
PR#81 added functions only provided by GnuTLS 3.4.0 and later, but did not bump the configure.ac check for GnuTLS to enforce that version as minimum.
rousskov
removed
M-failed-other
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 51e09c0 (GitHub PR #81) added GnuTLS functions available starting
with GnuTLS v3.4.0 but did not bump the ./configure check accordingly.