Bug 4822: Build failure (-Wformat) where time_t is not long int#158
Merged
rousskov merged 1 commit intosquid-cache:masterfrom Feb 24, 2018
Merged
Conversation
There is no good way to printf() time_t. AFAICT, Squid usually just casts to (long) int. TODO: Use C++ streams (with manipulators) instead.
Contributor
Author
|
Disclaimer: I have not tested this change beyond compilation. |
Contributor
Author
yadij
approved these changes
Feb 23, 2018
Contributor
yadij
left a comment
yadij
left a comment
There was a problem hiding this comment.
Danilo G. Baio 2018-02-22 19:45:50 UTC
"Building fine with this patch, thanks!"
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Feb 24, 2018
…d-cache#158) There is no good way to printf() time_t. AFAICT, Squid usually just casts to (long) int. TODO: Use C++ streams (with manipulators) instead.
yadij
pushed a commit
that referenced
this pull request
Feb 26, 2018
There is no good way to printf() time_t. AFAICT, Squid usually just casts to (long) int. TODO: Use C++ streams (with manipulators) instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There is no good way to printf() time_t. AFAICT, Squid usually just
casts to (long) int. TODO: Use C++ streams (with manipulators) instead.