Skip to content

Prep for 4.0.24#168

Merged
yadij merged 3 commits intosquid-cache:masterfrom
yadij:v4-release-notes
Mar 7, 2018
Merged

Prep for 4.0.24#168
yadij merged 3 commits intosquid-cache:masterfrom
yadij:v4-release-notes

Conversation

@yadij
Copy link
Contributor

@yadij yadij commented Mar 6, 2018

No description provided.

@yadij yadij force-pushed the v4-release-notes branch from e441554 to fe6deee Compare March 6, 2018 10:27
@yadij yadij requested a review from rousskov March 6, 2018 10:34
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have not reviewed the set of changes itemized/listed for v4.0.24 inclusion but left a few polishing comments.


<p>Also, be aware that the feature implementation is far from complete. The
popular SSL-Bump and certificate generation features are not yet supported
GnuTLS builds. Nor are many other less commonly used features.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/GnuTLS builds/by GnuTLS builds/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks. done

upstream TLS connections. Then you now have the choice to build Squid with
GnuTLS instead of OpenSSL.
<p>Squid can now be built to use GnuTLS in place of OpenSSL for the core
features of receiving TLS connections from clients, and making TLS
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/clients, /clients /

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

GnuTLS instead of OpenSSL.
<p>Squid can now be built to use GnuTLS in place of OpenSSL for the core
features of receiving TLS connections from clients, and making TLS
connection to servers. The GnuTLS support is still very much experimental
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/connection/connections/ for consistency with the previous "receiving" phrasing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

- TLS: GnuTLS implementation for listening ports and client connections
- TPROXY: Fix clientside_mark and client port logging
- Native FTP: Fix "Cannot assign requested address" with TPROXY
- SSL-Bump: Fix authentication with types other than Basic
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI: The far more prevalent, historically accurate, and slightly more logical spelling is SslBump. This commit does not introduce this (minor) problem to ChangeLog, but it can fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Historically it has been a mix. "SSL-Bump" is to refer to the 'project' grouping I have for these patches generic patches. References to "SslBump" are mostly referring to the original 3.0/3.1 code functionality which went in by that name (or the way people titled their commits). I have been referring to the overall feature set as "SSL-Bump" since the mimic and generation features were added onto the "SslBump" feature.

FYI: The reason behind using that different name has been to stop new people wanting help going to the "SslBump" wiki page as their first stop for Squid-3.4+ configuration info. Big red deprecation warnings on the page did not help, but this subtle change to the terminology name being searched for in Google et al seems to have worked.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"SSL-Bump" is to refer ...

SSL-Bump should not be used (for the reasons I have already provided). One cannot justify using a bad or inferior term by describing how it is to be used, by ignoring conflicting usages, or by mentioning bad wiki organization ideas, etc., etc. No need to respond though -- I have no time to fight this nonsense.

connection to servers. The GnuTLS support is still very much experimental
and should be tested before use.

<p>Also, be aware that the feature implementation is far from complete. The
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can drop the Also, be aware that fluff.

It is not clear what the feature is referring to. The earlier text talked about accepting and establishing TLS connections. It is not clear whether that implementation is incomplete, whether the SslBump features mentioned after this sentence are the missing parts, or whether some other important pieces are missing. What you have probably meant can be expressed like this:

GnuTLS coverage (of Squid features) is far from complete: SslBump and many other TLS-related features are not yet supported by GnuTLS builds.

You can keep or drop the parenthesized portion, depending on how precise you want this statement to be.

@rousskov
Copy link
Contributor

rousskov commented Mar 6, 2018

V4

Any chance you can start using a far more common way to refer to versions? Like v4 or Version 4? Your V4 looks odd and out of place IMHO; there are drinks and car engine architectures that are spelled like this.

Also, this PR is not about v4 release notes but v4.0.24 release notes. It is best to be precise when it does not cost much.

@yadij
Copy link
Contributor Author

yadij commented Mar 7, 2018

I think I mentioned it before, the "V4" is entirely generated by github. It uses the branch name when multiple commits are in the PR.

* Add Americanism's to the release notes text.

* Bump the release date to match rebiew delays.
@yadij yadij changed the title V4 release notes Prep for 4.0.24 Mar 7, 2018
@rousskov
Copy link
Contributor

rousskov commented Mar 7, 2018

GitHub is not responsible for Squid commit messages. I am sure you can fix it if you want to, regardless of what GitHub does by default.

@yadij yadij merged commit 2db9989 into squid-cache:master Mar 7, 2018
squidadm pushed a commit to squidadm/squid that referenced this pull request Mar 7, 2018
Also update mkrelease.sh script for git
yadij pushed a commit that referenced this pull request Mar 7, 2018
Also update mkrelease.sh script for git
@yadij yadij deleted the v4-release-notes branch June 28, 2018 02:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants