Update my e-mail address in CONTRIBUTORS#2
Closed
jwilk wants to merge 10000 commits intosquid-cache:masterfrom
jwilk:jwilk-contributors
Closed
Update my e-mail address in CONTRIBUTORS#2jwilk wants to merge 10000 commits intosquid-cache:masterfrom jwilk:jwilk-contributors
jwilk wants to merge 10000 commits intosquid-cache:masterfrom
jwilk:jwilk-contributors
Conversation
* fix convenience library dependency detection * convert to new base64 coding API * remove goto's
... and several bugs hidden by lack of this check: * url_rewrite_timeout parser/dumper using wrong cf.data.pre parameter definition. * url_rewrite_timeout parser/dumper using wrong object for state data. Global a Config object instead of parameter object. Preventing future use of multiple Config objects. There is more to be done as the Timeout value itself is not stored as part of the object apparently detailing the timeout. * request_header_add directive dump() omitting directive name in mgr:config output. * dead code as HTCP packet handlers for NOP, MON, SET * mime icons download operation incorrectly initialized. was using the 'view' access parameter to set download access permission. * peerCountHandleIcpReply() assertions testing validity after pointers already used. This would lead to segfault on errors, now leading to assertion logging. Only the default built code was checked and updated at this time. There are 62 known warnings still appearing due to parameters being only used inside conditional code, possibly more issues in code not enabled in this build and certainly a lot more in the stubs and unit tests which were not checked.
* Digest auth header field-value parser * HTTP header statistics state data * logformat parser token data
Solaris 10+ bundles IPFilter code natively, but the IPFilter headers contain a duplicate definition of minor_t which does not match the existing OS definition. The result is that no applications (such as Squid) will build on Solaris with the natively provided headers. Also, the upstream IPFilter code separate from Solaris contains the same minor_t definition so building against a separate install of IPFilter does not fix the issue. We must instead play fancy games #define'ing minor_t to a different real-name for the OS headers and its own name for the IPFilter headers. Thanks to Yuri Voinov for sponsoring the Solaris 10 machine and environment resources for this fix.
clang uncovered several conditionals which could never be true. Removed the conditionals entirely.
…yTagged accessing SplayNodes, prevented Splay leaks on several ACL types
"type qualifier on return type is meaningless"
BodyPipe is ref-counted. Such classes should not be using CBDATA_CLASS for smart pointer referencing and memory management. They use RefCount for smart pointer referencing, MEMPROXY_CLASS for memory management.
We are not supporting SSLv2 features anymore.
Compression in SSL/TLS is deprecated. LibreSSL, BoringSSL, and some OpenSSL builds do not contain support for it at all.
Detected by Coverity Scan. Issue 1273439
Detected by Coverity Scan. Issue 1273438
Being overly paranoid it seems. Detected by Coverity Scan. Issue 1273436
Detected by Coverity Scan. Issue 1270007
Detected by Coverity Scan. Issue 740575
We are getting come complaints about precompiler issues building with #if FOO && FOO || FOO boolean constructs using undefined macros. The particualr form reported so far dies when building the test, so will be found earlier than these checks are run. This is to ensure its not a widespread subtle error in other "working" installations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.