Update source-maintenance script for git#26
Merged
yadij merged 1 commit intosquid-cache:masterfrom Jul 21, 2017
Merged
Conversation
* replace bzr calls with git equivalent * remove obsolete ROOT and PWD variables (git does not support non-recursive file listing) * add exceptions to ignore more files caught by git than bzr
Contributor
It is even more complicated because the current script might seriously damage the code and because it is Wrong (tm) to commit anything without review. The ideal solution we should be moving towards is to both
Item 1 may not be a good idea without item 2 because manually running the formatter is currently a little difficult. AFAIK, there are projects that already do this kind of stuff but it is all custom software that is difficult to reuse. We may have to live with a commit hook (like we did with bzr) until item 2 is available. |
rousskov
approved these changes
Jul 20, 2017
Contributor
rousskov
left a comment
rousskov
left a comment
There was a problem hiding this comment.
I did not review closely but saw no problems.
yadij
added a commit
to yadij/squid
that referenced
this pull request
Jul 22, 2017
* replace bzr calls with git equivalent * remove obsolete ROOT and PWD variables (git does not support non-recursive file listing) * add exceptions to ignore more files caught by git than bzr
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Aug 19, 2017
* replace bzr calls with git equivalent * remove obsolete ROOT and PWD variables (git does not support non-recursive file listing) * add exceptions to ignore more files caught by git than bzr
yadij
pushed a commit
that referenced
this pull request
Aug 19, 2017
* Maintenance: update snapshot script for git (#24) * Update snapshot script after git migration - Remove unused BZRROOT environment variable - Replace tag with branch name * Update source-maintenance script for git (#26) * replace bzr calls with git equivalent * remove obsolete ROOT and PWD variables (git does not support non-recursive file listing) * add exceptions to ignore more files caught by git than bzr * Maintenance: remove unused .bzrignore (#29) * Remove .bzrignore from git * Prep for 3.5.27 * SourceFormat Enforcement
squidadm
added a commit
to squidadm/squid
that referenced
this pull request
Aug 19, 2017
* Maintenance: update snapshot script for git (squid-cache#24) * Update snapshot script after git migration - Remove unused BZRROOT environment variable - Replace tag with branch name * Update source-maintenance script for git (squid-cache#26) * replace bzr calls with git equivalent * remove obsolete ROOT and PWD variables (git does not support non-recursive file listing) * add exceptions to ignore more files caught by git than bzr * Maintenance: remove unused .bzrignore (squid-cache#29) * Remove .bzrignore from git * Prep for 3.5.27 * SourceFormat Enforcement
yadij
pushed a commit
that referenced
this pull request
Aug 19, 2017
* Prep for 3.5.27 (#48) * Maintenance: update snapshot script for git (#24) * Update snapshot script after git migration - Remove unused BZRROOT environment variable - Replace tag with branch name * Update source-maintenance script for git (#26) * replace bzr calls with git equivalent * remove obsolete ROOT and PWD variables (git does not support non-recursive file listing) * add exceptions to ignore more files caught by git than bzr * Maintenance: remove unused .bzrignore (#29) * Remove .bzrignore from git * Prep for 3.5.27 * SourceFormat Enforcement * 3.5.27
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NOTE: most of this script should become commit hooks for git, but the CI infrastructure needs more development for that. So for now just updating the script we have, so it can continue its work meanwhile.