Bug 4718: Support filling raw buffer space of shared SBufs#87
Closed
chtsanti wants to merge 1 commit intosquid-cache:v4.0from
Closed
Bug 4718: Support filling raw buffer space of shared SBufs#87chtsanti wants to merge 1 commit intosquid-cache:v4.0from
chtsanti wants to merge 1 commit intosquid-cache:v4.0from
Conversation
SBuf::forceSize() requires exclusive SBuf ownership but its precursor SBuf::rawSpace() method does not guarantee exclusivity. The pair of calls may result in SBuf::forceSize() throwing for no good reason. New SBuf API provides a new pair of raw buffer appending calls that reduces the number of false negatives. This change may alleviate bug 4718 symptoms but does not address its core problem (which is still unconfirmed). This is a Measurement Factory project. Port from master commit 672337d
rousskov
added
the
S-waiting-for-maintainer
Contributor
|
FYI: I have created (and used here) a new S-waiting-for-maintainer label because non-master commits should be done by the branch maintainer rather than anybody with write access. This label will make it easier to find porting PRs. However, if you think we should just search for non-master targeting PRs that have S-waiting-for-committer label instead, then we can remove this new label. |
Contributor
|
Included in PR #93 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SBuf::forceSize() requires exclusive SBuf ownership but its precursor
SBuf::rawSpace() method does not guarantee exclusivity. The pair of
calls may result in SBuf::forceSize() throwing for no good reason.
New SBuf API provides a new pair of raw buffer appending calls that
reduces the number of false negatives.
This change may alleviate bug 4718 symptoms but does not address its
core problem (which is still unconfirmed).
This is a Measurement Factory project.
Port from master commit 672337d
Originally discussed under PR #64