Bug 5177: clientca certificates sent to https_port clients#955
Closed
rousskov wants to merge 1 commit intosquid-cache:masterfrom
Closed
Conversation
When sending an https_port _server_ certificate chain to the client, Squid may send intermediate CA certificates found in clientca=... or tls-cafile=... client certificate bundles. This "leak" of client CAs surprises admins, may trigger traffic monitoring alarms, and might even break https_port certificate validation in some TLS clients. This surprising "leak" of client CAs is triggered by OpenSSL default behavior of auto-completing server certificate chains using whatever CA certificates happened to be in the TLS context certificate store. When client certificate authentication is enabled, that store may contain clientca CAs (or equivalent). OpenSSL CHANGES file acknowledges that this aggressive default behavior can be a problem and introduces SSL_MODE_NO_AUTO_CHAIN as a way to disable it. This fix breaks misconfigured Squid deployments that (usually unknowingly) rely on the OpenSSL clientca "leak" to build a complete https_port server certificate chain sent to TLS clients. Such deployments should add the right intermediate CA certificate(s) to their https_port tls-cert=... bundle (or equivalent).
rousskov
force-pushed
the
SQUID-642-bug5177-do-not-chain-clientca-to-portcert
branch
from
e90e24b to
ffcac5e
Compare
yadij
approved these changes
Jan 7, 2022
yadij
added
the
M-cleared-for-merge
squid-anubis
pushed a commit
that referenced
this pull request
Jan 9, 2022
When sending an https_port _server_ certificate chain to the client, Squid may send intermediate CA certificates found in clientca=... or tls-cafile=... client certificate bundles. This "leak" of client CAs surprises admins, may trigger traffic monitoring alarms, and might even break https_port certificate validation in some TLS clients. This surprising "leak" of client CAs is triggered by OpenSSL default behavior of auto-completing server certificate chains using whatever CA certificates happened to be in the TLS context certificate store. When client certificate authentication is enabled, that store may contain clientca CAs (or equivalent). OpenSSL CHANGES file acknowledges that this aggressive default behavior can be a problem and introduces SSL_MODE_NO_AUTO_CHAIN as a way to disable it. This fix breaks misconfigured Squid deployments that (usually unknowingly) rely on the OpenSSL clientca "leak" to build a complete https_port server certificate chain sent to TLS clients. Such deployments should add the right intermediate CA certificate(s) to their https_port tls-cert=... bundle (or equivalent). This is a Measurement Factory project.
squid-anubis
added
the
M-waiting-staging-checks
squid-anubis
added
M-merged
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Jan 18, 2022
…he#955) When sending an https_port _server_ certificate chain to the client, Squid may send intermediate CA certificates found in clientca=... or tls-cafile=... client certificate bundles. This "leak" of client CAs surprises admins, may trigger traffic monitoring alarms, and might even break https_port certificate validation in some TLS clients. This surprising "leak" of client CAs is triggered by OpenSSL default behavior of auto-completing server certificate chains using whatever CA certificates happened to be in the TLS context certificate store. When client certificate authentication is enabled, that store may contain clientca CAs (or equivalent). OpenSSL CHANGES file acknowledges that this aggressive default behavior can be a problem and introduces SSL_MODE_NO_AUTO_CHAIN as a way to disable it. This fix breaks misconfigured Squid deployments that (usually unknowingly) rely on the OpenSSL clientca "leak" to build a complete https_port server certificate chain sent to TLS clients. Such deployments should add the right intermediate CA certificate(s) to their https_port tls-cert=... bundle (or equivalent). This is a Measurement Factory project.
squidadm
pushed a commit
to squidadm/squid
that referenced
this pull request
Mar 30, 2022
…he#955) When sending an https_port _server_ certificate chain to the client, Squid may send intermediate CA certificates found in clientca=... or tls-cafile=... client certificate bundles. This "leak" of client CAs surprises admins, may trigger traffic monitoring alarms, and might even break https_port certificate validation in some TLS clients. This surprising "leak" of client CAs is triggered by OpenSSL default behavior of auto-completing server certificate chains using whatever CA certificates happened to be in the TLS context certificate store. When client certificate authentication is enabled, that store may contain clientca CAs (or equivalent). OpenSSL CHANGES file acknowledges that this aggressive default behavior can be a problem and introduces SSL_MODE_NO_AUTO_CHAIN as a way to disable it. This fix breaks misconfigured Squid deployments that (usually unknowingly) rely on the OpenSSL clientca "leak" to build a complete https_port server certificate chain sent to TLS clients. Such deployments should add the right intermediate CA certificate(s) to their https_port tls-cert=... bundle (or equivalent). This is a Measurement Factory project.
yadij
pushed a commit
that referenced
this pull request
Apr 1, 2022
When sending an https_port _server_ certificate chain to the client, Squid may send intermediate CA certificates found in clientca=... or tls-cafile=... client certificate bundles. This "leak" of client CAs surprises admins, may trigger traffic monitoring alarms, and might even break https_port certificate validation in some TLS clients. This surprising "leak" of client CAs is triggered by OpenSSL default behavior of auto-completing server certificate chains using whatever CA certificates happened to be in the TLS context certificate store. When client certificate authentication is enabled, that store may contain clientca CAs (or equivalent). OpenSSL CHANGES file acknowledges that this aggressive default behavior can be a problem and introduces SSL_MODE_NO_AUTO_CHAIN as a way to disable it. This fix breaks misconfigured Squid deployments that (usually unknowingly) rely on the OpenSSL clientca "leak" to build a complete https_port server certificate chain sent to TLS clients. Such deployments should add the right intermediate CA certificate(s) to their https_port tls-cert=... bundle (or equivalent). This is a Measurement Factory project.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When sending an https_port server certificate chain to the client,
Squid may send intermediate CA certificates found in clientca=... or
tls-cafile=... client certificate bundles. This "leak" of client CAs
surprises admins, may trigger traffic monitoring alarms, and might even
break https_port certificate validation in some TLS clients.
This surprising "leak" of client CAs is triggered by OpenSSL default
behavior of auto-completing server certificate chains using whatever CA
certificates happened to be in the TLS context certificate store. When
client certificate authentication is enabled, that store may contain
clientca CAs (or equivalent). OpenSSL CHANGES file acknowledges that
this aggressive default behavior can be a problem and introduces
SSL_MODE_NO_AUTO_CHAIN as a way to disable it.
This fix breaks misconfigured Squid deployments that (usually
unknowingly) rely on the OpenSSL clientca "leak" to build a complete
https_port server certificate chain sent to TLS clients. Such
deployments should add the right intermediate CA certificate(s) to their
https_port tls-cert=... bundle (or equivalent).
This is a Measurement Factory project.