Skip to content

Fixed %ssl::<cert_issuer documentation typo in e2e33ac#99

Merged
yadij merged 1 commit intosquid-cache:masterfrom
measurement-factory:fix-PR83
Dec 11, 2017
Merged

Fixed %ssl::<cert_issuer documentation typo in e2e33ac#99
yadij merged 1 commit intosquid-cache:masterfrom
measurement-factory:fix-PR83

Conversation

@chtsanti
Copy link
Contributor

@chtsanti chtsanti commented Dec 8, 2017

TODO: Migrate from plain text to structured cf.data.pre.

Fix typo bug for ssl::<cert_issuer documentation entry.
@rousskov rousskov changed the title Fix commit e2e33acc521f216af229e62a4db5a92b61d7126e PR#83 Fixed %ssl::<cert_issuer documentation typo in e2e33ac. Dec 8, 2017
Copy link
Contributor

@rousskov rousskov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for fixing this.

@rousskov rousskov changed the title Fixed %ssl::<cert_issuer documentation typo in e2e33ac. Fixed %ssl::<cert_issuer documentation typo in e2e33ac Dec 8, 2017
@rousskov
Copy link
Contributor

rousskov commented Dec 9, 2017

@kinkie, do you know why the Jenkins test is stuck even though the console shows failure? What does Jenkins wait for? A crashed plugin to update some Jenkins state?

Also, do you know why that particular test failed to checkout 3f0bea2?

hudson.plugins.git.GitException: Command "git checkout -f 3f0bea256d6f458d1d965a10cc55d577e113e71f" returned status code 128:
stderr: fatal: reference is not a tree: 3f0bea256d6f458d1d965a10cc55d577e113e71f

Finally, is there a way to add precise timestamps to Jenkins console logs? It could help triage race conditions like GitHub-generated merge commits that disappear for a second or two.

@yadij
Copy link
Contributor

yadij commented Dec 11, 2017

Seems to have been waiting on the final sub-test to complete. That is now done and the QA shows a pass.

@yadij yadij merged commit 8f1c609 into squid-cache:master Dec 11, 2017
@rousskov
Copy link
Contributor

@yadij, thank you for merging!

@kinkie, the questions in my previous comment are still open. Please note that they are based on the now-failed build 184 which, IIRC, at the time of my comment, was stuck with all blue tests except the one I linked to. Its current summary picture looks different (with more similar failures). I am guessing that the completed build Amos is referring to above is build 186.

@chtsanti chtsanti deleted the fix-PR83 branch December 12, 2017 09:37
squidadm pushed a commit to squidadm/squid that referenced this pull request Jan 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants