add support for Google Cloud Storage#182
Merged
smacker merged 1 commit intosrc-d:masterfrom Jan 24, 2019
smacker:add_gcs_support
Merged
add support for Google Cloud Storage#182smacker merged 1 commit intosrc-d:masterfrom smacker:add_gcs_support
smacker merged 1 commit intosrc-d:masterfrom
smacker:add_gcs_support
Conversation
- Allows to use gcs path for files as: gcs://bucket/path - Adds new flag --gcs-keyfile to hash command for authorization I added gcs-connector to the deps jar instead of sending it separatly to spark due to conflicts in guava between spark 2.2 and gcs-connector. I also updated scalapb to avoid multiple shading of guava for gcs-connector and grpc separatly. Now both use compatible versions. Signed-off-by: Maxim Sukharev <max@smacker.ru>
carlosms
approved these changes
Jan 24, 2019
smola
approved these changes
Jan 24, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I added gcs-connector to the deps jar instead of sending it separatly to
spark due to conflicts in guava between spark 2.2 and gcs-connector.
I also updated scalapb to avoid multiple shading of guava for
gcs-connector and grpc separatly. Now both use compatible versions.
Signed-off-by: Maxim Sukharev max@smacker.ru