create WMH only once and broadcast#194
Merged
smacker merged 1 commit intosrc-d:masterfrom Feb 7, 2019
smacker:broadcast_wmh
Merged
create WMH only once and broadcast#194smacker merged 1 commit intosrc-d:masterfrom smacker:broadcast_wmh
smacker merged 1 commit intosrc-d:masterfrom
smacker:broadcast_wmh
Conversation
An instance of whm is relatively huge and slow to create On ~500 middle-size repositories it consumers ~4G of memory Signed-off-by: Maxim Sukharev <max@smacker.ru>
|
I never used broadcast, it's really interesting. 👍 LGTM. |
se7entyse7en
approved these changes
Feb 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An instance of whm is relatively huge and slow to create
On ~500 middle-size repositories it consumers ~4G of memory
In my tests it causes lots of CPU consumption and currently on my dataset worker just stops responding to heartbeat checks.
Signed-off-by: Maxim Sukharev max@smacker.ru