Add github api retries#45
Merged
Merged
Conversation
smacker
reviewed
Jun 20, 2019
Contributor
There was a problem hiding this comment.
maybe it's better to implement on transport level? (http.RoundTripper)
then all the request can be wrapped into retry automatically? Less code, less chance to make a mistake.
Contributor
Author
|
Changed to be a RoundTripper in d7b18c5. |
smacker
approved these changes
Jun 20, 2019
dpordomingo
approved these changes
Jun 20, 2019
Signed-off-by: Carlos Martín <carlos.martin.sanchez@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #37.
The logs will look like this: