Skip to content

[RFC] Apply our brand colors on source{d} charts #241

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
dpordomingo wants to merge 6 commits into from
Closed

[RFC] Apply our brand colors on source{d} charts #241

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3c4c93c
Add the new theme with source{d} theme
dpordomingo Jul 31, 2019
9889bf4
Make srcdMain the default palette for SUPERSET_DEFAULT key
dpordomingo Jul 31, 2019
fe18682
Make SUPERSET_DEFAULT the default palett for CategoricalScheme
dpordomingo Aug 6, 2019
2f06d2c
Make SUPERSET_DEFAULT the default on ColorScheme selectors
dpordomingo Jul 31, 2019
f758a82
Set default color_scheme in our charts
dpordomingo Aug 6, 2019
eadfeb3
Use simpler palettes for charts with only a few metrics
dpordomingo Aug 6, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions srcd/dashboards/gitbase/overview.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"datasource_name": "gitbase.admin admin-commit_merges-8X2HBrQre",
"datasource_type": "table",
"id": 9,
"params": "{\"adhoc_filters\": [], \"annotation_layers\": [], \"bottom_margin\": \"auto\", \"color_scheme\": \"bnbColors\", \"comparison_type\": \"values\", \"contribution\": false, \"datasource\": \"14__table\", \"granularity_sqla\": \"commit_author_when\", \"groupby\": [\"commit_type\"], \"line_interpolation\": \"linear\", \"metrics\": [{\"aggregate\": null, \"column\": null, \"expressionType\": \"SQL\", \"fromFormData\": true, \"hasCustomLabel\": false, \"label\": \"COUNT(*)\", \"optionName\": \"metric_n4xn9emh55_60hid92bszp\", \"sqlExpression\": \"COUNT(*)\"}], \"order_desc\": true, \"resample_fillmethod\": null, \"resample_how\": null, \"resample_rule\": null, \"rich_tooltip\": true, \"rolling_type\": \"None\", \"row_limit\": 50000, \"show_brush\": \"auto\", \"show_controls\": false, \"show_legend\": true, \"slice_id\": 4, \"stacked_style\": \"stack\", \"time_grain_sqla\": \"P1M\", \"time_range\": \"100 years ago : \", \"timeseries_limit_metric\": null, \"viz_type\": \"area\", \"x_axis_format\": \"smart_date\", \"x_axis_label\": \"\", \"x_axis_showminmax\": false, \"x_ticks_layout\": \"auto\", \"y_axis_bounds\": [null, null], \"y_axis_format\": \".3s\", \"y_log_scale\": false, \"remote_id\": \"be4154a6-726c-4dcc-bcff-da20558aaa55\", \"datasource_name\": \"gitbase.admin admin-commit_merges-8X2HBrQre\", \"schema\": \"gitbase.admin admin-commit_merges-8X2HBrQre\", \"database_name\": \"gitbase\"}",
"params": "{\"adhoc_filters\": [], \"annotation_layers\": [], \"bottom_margin\": \"auto\", \"color_scheme\": \"srcdRoyal\", \"comparison_type\": \"values\", \"contribution\": false, \"datasource\": \"14__table\", \"granularity_sqla\": \"commit_author_when\", \"groupby\": [\"commit_type\"], \"line_interpolation\": \"linear\", \"metrics\": [{\"aggregate\": null, \"column\": null, \"expressionType\": \"SQL\", \"fromFormData\": true, \"hasCustomLabel\": false, \"label\": \"COUNT(*)\", \"optionName\": \"metric_n4xn9emh55_60hid92bszp\", \"sqlExpression\": \"COUNT(*)\"}], \"order_desc\": true, \"resample_fillmethod\": null, \"resample_how\": null, \"resample_rule\": null, \"rich_tooltip\": true, \"rolling_type\": \"None\", \"row_limit\": 50000, \"show_brush\": \"auto\", \"show_controls\": false, \"show_legend\": true, \"slice_id\": 4, \"stacked_style\": \"stack\", \"time_grain_sqla\": \"P1M\", \"time_range\": \"100 years ago : \", \"timeseries_limit_metric\": null, \"viz_type\": \"area\", \"x_axis_format\": \"smart_date\", \"x_axis_label\": \"\", \"x_axis_showminmax\": false, \"x_ticks_layout\": \"auto\", \"y_axis_bounds\": [null, null], \"y_axis_format\": \".3s\", \"y_log_scale\": false, \"remote_id\": \"be4154a6-726c-4dcc-bcff-da20558aaa55\", \"datasource_name\": \"gitbase.admin admin-commit_merges-8X2HBrQre\", \"schema\": \"gitbase.admin admin-commit_merges-8X2HBrQre\", \"database_name\": \"gitbase\"}",
Copy link
Copy Markdown
Contributor

@se7entyse7en se7entyse7en Aug 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR, but it came to my mind now.

@smacker is this the result of a json.dumps(params) during export? If it is so, do you think that it could make sense to replace it with a json.dumps(params, indent=4) where params is an OrderedDict? It should simplify the diff as each key would be in different rows.

Copy link
Copy Markdown
Contributor Author

@dpordomingo dpordomingo Aug 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just edited current dashboards, but I agree with you @se7entyse7en; diffs would be better if we could have better formatted this section.

Copy link
Copy Markdown
Contributor

@se7entyse7en se7entyse7en Aug 7, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just edited current dashboards

Yup, I imagined that, and thanks for posting the screenshots! 👍

Copy link
Copy Markdown
Contributor

@smacker smacker Aug 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is just a value from a database column which can be either empty string or serialized json. In theory, we can amend import/export to serialize it differently. But I wouldn't hack import/export anymore until apache/superset#7829 is merged into upstream, released and merged into our fork.

Copy link
Copy Markdown
Contributor

@se7entyse7en se7entyse7en Aug 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay! Thanks for the info! 👍

"slice_name": "Commits Evolution",
"viz_type": "area"
}
Expand Down Expand Up @@ -91,7 +91,7 @@
"datasource_name": "gitbase.admin admin-commits_per_day-lGJ1u0Kbm",
"datasource_type": "table",
"id": 11,
"params": "{\"adhoc_filters\": [], \"bar_stacked\": true, \"bottom_margin\": \"auto\", \"color_scheme\": \"bnbColors\", \"columns\": [\"commit_type\"], \"contribution\": false, \"datasource\": \"16__table\", \"granularity_sqla\": null, \"groupby\": [\"day\"], \"metrics\": [\"count\"], \"order_bars\": true, \"reduce_x_ticks\": false, \"row_limit\": 50000, \"show_bar_value\": true, \"show_controls\": false, \"show_legend\": true, \"slice_id\": 6, \"time_grain_sqla\": \"P1D\", \"time_range\": \"100 years ago : \", \"viz_type\": \"dist_bar\", \"x_axis_label\": \"Day of the week\", \"x_ticks_layout\": \"auto\", \"y_axis_format\": \".3s\", \"y_axis_label\": \"Number of imports\", \"remote_id\": \"165563fc-6483-4c74-ad9b-13cba38c4752\", \"datasource_name\": \"gitbase.admin admin-commits_per_day-lGJ1u0Kbm\", \"schema\": \"gitbase.admin admin-commits_per_day-lGJ1u0Kbm\", \"database_name\": \"gitbase\"}",
"params": "{\"adhoc_filters\": [], \"bar_stacked\": true, \"bottom_margin\": \"auto\", \"color_scheme\": \"srcdRoyal\", \"columns\": [\"commit_type\"], \"contribution\": false, \"datasource\": \"16__table\", \"granularity_sqla\": null, \"groupby\": [\"day\"], \"metrics\": [\"count\"], \"order_bars\": true, \"reduce_x_ticks\": false, \"row_limit\": 50000, \"show_bar_value\": true, \"show_controls\": false, \"show_legend\": true, \"slice_id\": 6, \"time_grain_sqla\": \"P1D\", \"time_range\": \"100 years ago : \", \"viz_type\": \"dist_bar\", \"x_axis_label\": \"Day of the week\", \"x_ticks_layout\": \"auto\", \"y_axis_format\": \".3s\", \"y_axis_label\": \"Number of imports\", \"remote_id\": \"165563fc-6483-4c74-ad9b-13cba38c4752\", \"datasource_name\": \"gitbase.admin admin-commits_per_day-lGJ1u0Kbm\", \"schema\": \"gitbase.admin admin-commits_per_day-lGJ1u0Kbm\", \"database_name\": \"gitbase\"}",
"slice_name": "Number of commits per day of the week",
"viz_type": "dist_bar"
}
Expand All @@ -113,7 +113,7 @@
"datasource_name": "null.admin admin-Untitled Query-0scA3HaD5",
"datasource_type": "table",
"id": 8,
"params": "{\"adhoc_filters\": [], \"annotation_layers\": [], \"bar_stacked\": true, \"bottom_margin\": \"auto\", \"color_scheme\": \"d3Category10\", \"comparison_type\": \"values\", \"contribution\": false, \"datasource\": \"19__table\", \"granularity_sqla\": \"commit_author_when\", \"groupby\": [], \"left_margin\": \"auto\", \"line_interpolation\": \"linear\", \"metrics\": [\"count\"], \"order_desc\": true, \"reduce_x_ticks\": false, \"resample_fillmethod\": null, \"resample_how\": null, \"resample_rule\": null, \"rich_tooltip\": true, \"rolling_type\": \"None\", \"row_limit\": 1000, \"show_bar_value\": false, \"show_brush\": \"auto\", \"show_controls\": false, \"show_legend\": false, \"time_grain_sqla\": \"P1M\", \"time_range\": \"100 years ago : \", \"timeseries_limit_metric\": null, \"url_params\": {}, \"viz_type\": \"bar\", \"x_axis_format\": \"%b/%y\", \"x_axis_label\": \"\", \"x_axis_showminmax\": false, \"x_ticks_layout\": \"auto\", \"y_axis_bounds\": [null, null], \"y_axis_format\": null, \"y_axis_label\": \"\", \"y_axis_showminmax\": false, \"y_log_scale\": false, \"remote_id\": \"8d4124f8-568d-4e51-abf3-0118cf5d381e\", \"datasource_name\": \"null.admin admin-Untitled Query-0scA3HaD5\", \"schema\": \"null.admin admin-Untitled Query-0scA3HaD5\", \"database_name\": \"gitbase\"}",
"params": "{\"adhoc_filters\": [], \"annotation_layers\": [], \"bar_stacked\": true, \"bottom_margin\": \"auto\", \"color_scheme\": \"srcdRoyal\", \"comparison_type\": \"values\", \"contribution\": false, \"datasource\": \"19__table\", \"granularity_sqla\": \"commit_author_when\", \"groupby\": [], \"left_margin\": \"auto\", \"line_interpolation\": \"linear\", \"metrics\": [\"count\"], \"order_desc\": true, \"reduce_x_ticks\": false, \"resample_fillmethod\": null, \"resample_how\": null, \"resample_rule\": null, \"rich_tooltip\": true, \"rolling_type\": \"None\", \"row_limit\": 1000, \"show_bar_value\": false, \"show_brush\": \"auto\", \"show_controls\": false, \"show_legend\": false, \"time_grain_sqla\": \"P1M\", \"time_range\": \"100 years ago : \", \"timeseries_limit_metric\": null, \"url_params\": {}, \"viz_type\": \"bar\", \"x_axis_format\": \"%b/%y\", \"x_axis_label\": \"\", \"x_axis_showminmax\": false, \"x_ticks_layout\": \"auto\", \"y_axis_bounds\": [null, null], \"y_axis_format\": null, \"y_axis_label\": \"\", \"y_axis_showminmax\": false, \"y_log_scale\": false, \"remote_id\": \"8d4124f8-568d-4e51-abf3-0118cf5d381e\", \"datasource_name\": \"null.admin admin-Untitled Query-0scA3HaD5\", \"schema\": \"null.admin admin-Untitled Query-0scA3HaD5\", \"database_name\": \"gitbase\"}",
"slice_name": "Number of commits to HEAD per month",
"viz_type": "bar"
}
Expand Down Expand Up @@ -168,7 +168,7 @@
"datasource_name": "null.admin admin-Untitled Query-aI5FBm-R2",
"datasource_type": "table",
"id": 6,
"params": "{\"adhoc_filters\": [], \"annotation_layers\": [], \"bar_stacked\": true, \"bottom_margin\": \"auto\", \"color_scheme\": \"bnbColors\", \"comparison_type\": \"values\", \"contribution\": false, \"datasource\": \"34__table\", \"granularity_sqla\": \"date_release\", \"groupby\": [\"repository_id\"], \"left_margin\": \"auto\", \"line_interpolation\": \"linear\", \"metrics\": [{\"aggregate\": \"SUM\", \"column\": {\"column_name\": \"n\", \"database_expression\": null, \"description\": null, \"expression\": \"\", \"filterable\": true, \"groupby\": true, \"id\": 124, \"is_dttm\": false, \"optionName\": \"_col_n\", \"python_date_format\": null, \"type\": \"LONGLONG\", \"verbose_name\": null}, \"expressionType\": \"SIMPLE\", \"fromFormData\": true, \"hasCustomLabel\": false, \"label\": \"SUM(n)\", \"optionName\": \"metric_uv459jfkfhb_jl45fbpfhpe\", \"sqlExpression\": null}], \"order_desc\": true, \"reduce_x_ticks\": false, \"resample_fillmethod\": null, \"resample_how\": null, \"resample_rule\": null, \"rich_tooltip\": true, \"rolling_type\": \"None\", \"row_limit\": 1000, \"show_bar_value\": false, \"show_brush\": \"auto\", \"show_controls\": false, \"show_legend\": false, \"slice_id\": 21, \"time_grain_sqla\": \"P1M\", \"time_range\": \"100 years ago : \", \"timeseries_limit_metric\": null, \"url_params\": {}, \"viz_type\": \"bar\", \"x_axis_format\": \"%b/%y\", \"x_axis_label\": \"\", \"x_axis_showminmax\": false, \"x_ticks_layout\": \"auto\", \"y_axis_bounds\": [null, null], \"y_axis_format\": null, \"y_axis_label\": \"\", \"y_axis_showminmax\": false, \"y_log_scale\": false, \"remote_id\": \"20da1b7e-7da6-48a9-b506-494f6584b258\", \"datasource_name\": \"null.admin admin-Untitled Query-aI5FBm-R2\", \"schema\": \"null.admin admin-Untitled Query-aI5FBm-R2\", \"database_name\": \"gitbase\"}",
"params": "{\"adhoc_filters\": [], \"annotation_layers\": [], \"bar_stacked\": true, \"bottom_margin\": \"auto\", \"color_scheme\": \"SUPERSET_DEFAULT\", \"comparison_type\": \"values\", \"contribution\": false, \"datasource\": \"34__table\", \"granularity_sqla\": \"date_release\", \"groupby\": [\"repository_id\"], \"left_margin\": \"auto\", \"line_interpolation\": \"linear\", \"metrics\": [{\"aggregate\": \"SUM\", \"column\": {\"column_name\": \"n\", \"database_expression\": null, \"description\": null, \"expression\": \"\", \"filterable\": true, \"groupby\": true, \"id\": 124, \"is_dttm\": false, \"optionName\": \"_col_n\", \"python_date_format\": null, \"type\": \"LONGLONG\", \"verbose_name\": null}, \"expressionType\": \"SIMPLE\", \"fromFormData\": true, \"hasCustomLabel\": false, \"label\": \"SUM(n)\", \"optionName\": \"metric_uv459jfkfhb_jl45fbpfhpe\", \"sqlExpression\": null}], \"order_desc\": true, \"reduce_x_ticks\": false, \"resample_fillmethod\": null, \"resample_how\": null, \"resample_rule\": null, \"rich_tooltip\": true, \"rolling_type\": \"None\", \"row_limit\": 1000, \"show_bar_value\": false, \"show_brush\": \"auto\", \"show_controls\": false, \"show_legend\": false, \"slice_id\": 21, \"time_grain_sqla\": \"P1M\", \"time_range\": \"100 years ago : \", \"timeseries_limit_metric\": null, \"url_params\": {}, \"viz_type\": \"bar\", \"x_axis_format\": \"%b/%y\", \"x_axis_label\": \"\", \"x_axis_showminmax\": false, \"x_ticks_layout\": \"auto\", \"y_axis_bounds\": [null, null], \"y_axis_format\": null, \"y_axis_label\": \"\", \"y_axis_showminmax\": false, \"y_log_scale\": false, \"remote_id\": \"20da1b7e-7da6-48a9-b506-494f6584b258\", \"datasource_name\": \"null.admin admin-Untitled Query-aI5FBm-R2\", \"schema\": \"null.admin admin-Untitled Query-aI5FBm-R2\", \"database_name\": \"gitbase\"}",
"slice_name": "Number of releases per month and repository",
"viz_type": "bar"
}
Expand Down Expand Up @@ -223,7 +223,7 @@
"datasource_name": "null.admin admin-Untitled Query-rpq4L7GFr",
"datasource_type": "table",
"id": 15,
"params": "{\"adhoc_filters\": [], \"bar_stacked\": false, \"bottom_margin\": 100, \"color_scheme\": \"SUPERSET_DEFAULT\", \"columns\": [], \"contribution\": false, \"datasource\": \"23__table\", \"granularity_sqla\": null, \"groupby\": [\"repository_id\"], \"metrics\": [{\"aggregate\": \"MAX\", \"column\": {\"column_name\": \"n\", \"database_expression\": null, \"description\": null, \"expression\": \"\", \"filterable\": true, \"groupby\": true, \"id\": 98, \"is_dttm\": false, \"python_date_format\": null, \"type\": \"LONGLONG\", \"verbose_name\": null}, \"expressionType\": \"SIMPLE\", \"fromFormData\": true, \"hasCustomLabel\": false, \"label\": \"MAX(n)\", \"optionName\": \"metric_ozqrfezkw4o_zf5mkt49ns\", \"sqlExpression\": null}], \"order_bars\": false, \"reduce_x_ticks\": false, \"row_limit\": 1000, \"show_bar_value\": false, \"show_controls\": false, \"show_legend\": false, \"slice_id\": 14, \"time_grain_sqla\": \"P1D\", \"time_range\": \"100 years ago : \", \"url_params\": {}, \"viz_type\": \"dist_bar\", \"x_axis_label\": \"\", \"x_ticks_layout\": \"staggered\", \"y_axis_format\": null, \"y_axis_label\": \"\", \"remote_id\": \"bdceb4b8-808e-47cc-84a3-f497d31c0dbc\", \"datasource_name\": \"null.admin admin-Untitled Query-rpq4L7GFr\", \"schema\": \"null.admin admin-Untitled Query-rpq4L7GFr\", \"database_name\": \"gitbase\"}",
"params": "{\"adhoc_filters\": [], \"bar_stacked\": false, \"bottom_margin\": 100, \"color_scheme\": \"srcdRoyal\", \"columns\": [], \"contribution\": false, \"datasource\": \"23__table\", \"granularity_sqla\": null, \"groupby\": [\"repository_id\"], \"metrics\": [{\"aggregate\": \"MAX\", \"column\": {\"column_name\": \"n\", \"database_expression\": null, \"description\": null, \"expression\": \"\", \"filterable\": true, \"groupby\": true, \"id\": 98, \"is_dttm\": false, \"python_date_format\": null, \"type\": \"LONGLONG\", \"verbose_name\": null}, \"expressionType\": \"SIMPLE\", \"fromFormData\": true, \"hasCustomLabel\": false, \"label\": \"MAX(n)\", \"optionName\": \"metric_ozqrfezkw4o_zf5mkt49ns\", \"sqlExpression\": null}], \"order_bars\": false, \"reduce_x_ticks\": false, \"row_limit\": 1000, \"show_bar_value\": false, \"show_controls\": false, \"show_legend\": false, \"slice_id\": 14, \"time_grain_sqla\": \"P1D\", \"time_range\": \"100 years ago : \", \"url_params\": {}, \"viz_type\": \"dist_bar\", \"x_axis_label\": \"\", \"x_ticks_layout\": \"staggered\", \"y_axis_format\": null, \"y_axis_label\": \"\", \"remote_id\": \"bdceb4b8-808e-47cc-84a3-f497d31c0dbc\", \"datasource_name\": \"null.admin admin-Untitled Query-rpq4L7GFr\", \"schema\": \"null.admin admin-Untitled Query-rpq4L7GFr\", \"database_name\": \"gitbase\"}",
"slice_name": "Total number of commits per repository",
"viz_type": "dist_bar"
}
Expand Down
Loading