Use SUPERSET_DEFAULT as the default palette#257
Merged
Conversation
dpordomingo
force-pushed
the
schemes-set-defaults
branch
from
1d6e82c to
378e9da
Compare
This was referenced Aug 15, 2019
Merged
carlosms
approved these changes
Aug 15, 2019
se7entyse7en
approved these changes
Aug 15, 2019
Superset is using 'SUPERSET_DEFAULT' as the default CategoricalScheme and SequentialScheme registries key i.e. https://github.com/apache-superset/superset-ui/blob/v0.11.3/packages/superset-ui-color/src/CategoricalSchemeRegistrySingleton.ts i.e. https://github.com/apache-superset/superset-ui/blob/v0.11.3/packages/superset-ui-color/src/SequentialSchemeRegistrySingleton.ts This commit assigns the current default palettes: 'bnbColors', 'blue_white_yellow', for 'SUPERSET_DEFAULT' key, for each respective SchemeRegistry. Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
It will set 'SUPERSET_DEFAULT' as the default option in 'Color Scheme' selector, (e.g. when creating a chart) This change modifies the current defaults: 'bnbColors' and 'blue_white_yellow' palettes for Categorical and Sequential schemes. It does not change currently configured schemes, but it will affect only the new charts if no other color is manually asigned. Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
dpordomingo
force-pushed
the
schemes-set-defaults
branch
from
378e9da to
8330721
Compare
Entrypoint to define our own colors, and use them in the application. Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
Instead of using 'bnbColors' or 'd3Category10' in our charts, it will be used the default color_scheme: 'SUPERSET_DEFAULT' Signed-off-by: David Pordomingo <David.Pordomingo.F@gmail.com>
dpordomingo
force-pushed
the
schemes-set-defaults
branch
from
8330721 to
a72e223
Compare
Contributor
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
supersedes #241 (This PR is the first stage, as defined by #241 (comment))
blocks #259
This PR prepares our charts and selectors to use the default palette:
SUPERSET_DEFAULTinstead of the currently hardcoded palettes (bnbColorsandblue_white_yellow).The colors of the palettes are kept, so this PR does not contain branding at all.
List of changes:
SUPERSET_DEFAULTas default for Categorical and Sequential Schemes instead of the currently hardcodedbnbColorsandblue_white_yellow. It will also use it as the default on ColorScheme selectors (e.g. when creating a chart)It does not change the palettes currently configured in our charts, but the new charts if no other color is manually assigned.
PRIMARY_COLORfully configurableSUPERSET_DEFAULTthe default palette forAnnotationLayerSUPERSET_DEFAULT, instead of the oldbnbColorsord3Category10.