Conversation
Extends DynamicSpec to exercise fmap (initial value + updater), pure (no-op updater), and liftA2 (combined initial value + updates from both sides, serialized by the internal sendLock). liftA2 is driven through currentValue and gated with MVars so the assertions don't rely on timing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
testtest-suite stanza toema.cabalso feature PRs can land unit tests alongside code.Ema.DynamicSpecexercisingEma.Dynamic.currentValue(Add Ema.Dynamic.currentValue for out-of-band reads #177): initial value before any update, and latest value after the wrapped updater runs.hspecrather thanhspec-discover— the nix-provided Haskell env does not expose thehspec-discoverexecutable, so specs are wired up manually intest/Spec.hs.Closes #178.
Test plan
cabal test --enable-tests ema:test:test— 2 of 2 passcabal-fmtandfourmolupre-commit hooks pass🤖 Generated with Claude Code