Conversation
shivaraj-bh
pushed a commit
to shivaraj-bh/emanote
that referenced
this pull request
Dec 18, 2023
* WIP use Text.Ginger * add more template vars * cleanups
This was referenced Apr 21, 2026
srid
added a commit
that referenced
this pull request
Apr 25, 2026
…-only Two related fixes for nix build .#docs: 1. Add more puppeteer args (--disable-dev-shm-usage, --disable-gpu, --disable-crash-reporter, --no-zygote, --single-process) on top of --no-sandbox / --disable-setuid-sandbox. The Nix build sandbox lacks /dev/shm and IPC capabilities Chromium expects, and the GitHub Actions runners we already had to placate. None of these touch sandboxing for mmdc's actual rendering — that runs against trusted local source. 2. Stop feeding mermaid render failures into the per-note error list. checkBadMarkdownFiles treats anything in there as fatal and calls exitFailure, so a single transient Chromium hiccup tanked the whole site build. Errors now go to the logger plus the visible inline "Mermaid rendering failed:" Para — readers and authors still see them at the right granularity, but the build keeps going. Trade-off: regresses the Hickey-#1 unification of error channels from the earlier review pass. Worth it: parse errors really should fail the build, render errors really shouldn't.
This was referenced Apr 25, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using https://ginger.tobiasdammers.nl/ | https://github.com/tdammers/ginger