Conversation
shivaraj-bh
pushed a commit
to shivaraj-bh/emanote
that referenced
this pull request
Dec 18, 2023
Introduce OutgoingRef index to IxSet
This was referenced Apr 21, 2026
srid
added a commit
that referenced
this pull request
Apr 29, 2026
…e haddock The CHANGELOG entry from the initial feature commit said the renderers threaded a `Set LMLRoute`, but the Hickey #4 + Lowy #5 follow-ups changed that to an opaque `EmbedStack` (list-backed). A future maintainer grepping the CHANGELOG for the implementation shape would have been misled. The `embedderRoute` parameter's Haddock claimed it was the route of "the note that contains this embed (the embedder)." That's true at depth 1 but false at deeper recursion — the dispatcher rebake rule preserves the original page route at every level, never updating it to the immediate parent. Restate the parameter's actual behaviour and note that the relative-link-base question is orthogonal to #362.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.