Merged
Conversation
Owner
Author
Hickey/Lowy AnalysisNo findings. Hickey: The change keeps the Emanote side simple: it pins the parser dependency, adds one narrow fixture, and checks the rendered link HTML without adding a parallel parsing path or extra abstraction. Lowy: The volatility boundary remains in the right place. Entity decoding behavior belongs to |
Owner
Author
8018d56 to
9a2fd47
Compare
Owner
Author
|
| Step | Status | Duration | Verification |
|---|---|---|---|
| sync | ✓ | 0s | git fetch ok; forge=github; noGit=false |
| research | ✓ | 5m 30s | Issue #441 traced to commonmark-wikilink pWikilink using untokenize for titles and token-level # splitting for references; Emanote consumes commonmark-wikilink via flake.nix input and haskell-flake package source override. |
| branch | ✓ | 18s | Created feature branch fix-wikilink-html-entities from origin/master. |
| implement | ✓ | 5m 58s | Merged commonmark-wikilink PR #9 upstream, locked Emanote to merged commonmark-wikilink master commit e47ba49, and added an e2e smoke regression for wiki link custom title entities. |
| check | ✓ | 1m 18s | nix develop -c cabal build all completed successfully against merged commonmark-wikilink 0.3.0.0 input e47ba49. |
| docs | ✓ | 22s | Updated emanote/CHANGELOG.md Unreleased bug fixes; README.md and docs/ did not need changes for this parser bug. |
| fmt | ✓ | 15s | just fmt completed: cabal-fmt, fourmolu, hlint, and nixpkgs-fmt passed. |
| commit | ✓ | 11s | Final commit 9a2fd47 created and pushed to origin/fix-wikilink-html-entities. |
| hickey+lowy | ✓ | 2m 41s | Hickey and Lowy sub-agents both produced reviews; no actions or deferrals. |
| police | ✓ | 1m 12s | code-police pass clean: rules, fact-check, and elegance found no issues. |
| test | ✓ | 1m 21s | just e2e-live, just e2e-static, and just e2e-morph were rerun in parallel on final HEAD 9a2fd47 and all passed; the wikilink entities regression scenario passed in all modes. |
| create-pr | ✓ | 33s | Created draft PR #680, updated it after dependency PR merge, and posted Hickey/Lowy no-findings analysis comment. |
| ci | ✓ | 16m 35s | Emanote vira ci passed for final HEAD 9a2fd47 with x86_64-linux and aarch64-darwin signoffs. just e2e-live, just e2e-static, and just e2e-morph passed in parallel on final HEAD. |
| evidence | ✓ | 11s | Posted Evidence comment to #680 (comment) with uploaded screenshot https://github.com/srid/emanote/releases/download/evidence-assets/emanote-evidence-wikilink-entities.png. |
| dependency-pr | ✓ | 0s | Dependency PR srid/commonmark-wikilink#9 was updated with a one-line PR-linked changelog and cabal version 0.3.0.0, had Hickey/Lowy and Code Police no-findings comments posted, was merged into master as e47ba49, and had vira ci passing on final branch head ea1e594. |
| Total | 38m 38s |
Slowest step: ci (16m 35s)
Optimization suggestions
- CI dominated the run; for follow-up-only changes on this PR, restart from the CI/e2e part instead of replaying the earlier research and implementation steps.
- The dependency PR changed after the Emanote PR was already opened, which forced a relock and another CI pass. For future dependency-backed fixes, finish dependency changelog/version/review/CI before opening the downstream PR.
- Keep the three e2e modes parallelized as in the final rerun; that kept the full e2e verification to roughly the slowest single mode instead of the sum of all three.
Workflow completed at 2026-04-27T02:01:10Z.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Wikilink custom titles now decode HTML entities the same way regular Markdown link labels do. This fixes cases like
[[note|Spivak (2014)]], which previously rendered the entity text literally in the visible title. Closes #441.The parser fix landed upstream in
commonmark-wikilinkvia srid/commonmark-wikilink#9, and this branch now pins Emanote to the mergedmastercommite47ba49. The upstream package was prepared as0.3.0.0, andvira cipassed there on the final PR head.The changelog records the user-visible bug fix, and the smoke fixture now exercises both live and static rendering paths for the entity-bearing wikilink title.
Generated by
/doon Codex (modelgpt-5).Try it locally