Merged
Conversation
Move the flake-specific Emanote package selection out of the generic Home Manager service module.
Owner
Author
Hickey/Lowy Analysis
The resulting boundary is intentionally narrow: direct imports of |
Owner
Author
|
| Step | Status | Duration | Verification |
|---|---|---|---|
| sync | passed | 1s | git fetch ok; forge=github; noGit=false |
| research | passed | 5m 46s | Issue #309 traced to nix/modules/home/emanote.nix defaulting to pkgs.emanote; planned self-backed module default plus Linux VM check. |
| branch | passed | 4s | Created fix-home-manager-module-vm-test from origin/master. |
| implement | passed | 13m 18s | Added self-backed homeManagerModule default, Linux VM check, and explicit root flake in vira.hs; VM check built successfully. |
| check | passed | 43s | nix develop -c cabal build all passed. |
| docs | passed | 26s | Updated Nix install docs and changelog. |
| fmt | passed | 10s | just fmt passed. |
| commit | passed | 57s | Created and pushed feature/docs commits. |
| hickey+lowy | passed | 5m 25s | Fixed shared package-default boundary finding in 9292ab48; Lowy finding was subsumed by the same fix. |
| police | passed | 3m 8s | Fixed missing release-check rationale comment; rules, fact-check, and elegance were clean afterward. |
| test | passed | 6s | nix build -L .#checks.x86_64-linux.home-manager-module --no-link passed. |
| create-pr | passed | 38s | Created draft PR #685 and posted Hickey/Lowy analysis. |
| ci | passed | 3m 31s | vira ci passed; signed off vira/aarch64-darwin and vira/x86_64-linux. |
| evidence | passed | 0s | No visible UI impact; PR evidence not required. |
| Total | 36m 22s |
Slowest step: implement at 13m 18s.
Process notes
The expensive part was iterating the VM service probe. Future NixOS VM tests like this should start with a bounded HTTP probe (curl --max-time) and an explicit user-systemd environment when checking user services from the test driver.
srid
commented
Apr 29, 2026
srid
added a commit
that referenced
this pull request
Apr 29, 2026
Brings in #685 (Home Manager module package default) and the agency chore commit so this PR sits on top of latest master. # Conflicts: # emanote/CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
emanote.homeManagerModulenow works without a manual package override, fixing the failure reported in #309. The flake-level Home Manager export supplies Emanote's own default package, while the reusable module keeps its plainpkgs.emanotedefault for non-flake imports.The regression is covered by a Linux NixOS VM test flake under
nix/home-manager-test. It importsemanote.homeManagerModule, enables the user service without settingservices.emanote.package, waits foremanote.service, and confirms the local HTTP server responds. Vira builds this test flake directly and overrides itsemanoteinput to the checked-out PR tree.Notable details
nixpkgs.vira.hsnow builds both the root flake and./nix/home-manager-test.package = ...as an optional override rather than a required workaround.Verification
nix develop -c cabal build all just fmt nix build -L ./nix/home-manager-test --override-input emanote . --no-linkCloses #309.
Try it locally
nix build 'github:srid/emanote/fix-home-manager-module-vm-test?dir=nix/home-manager-test' \ --override-input emanote github:srid/emanote/fix-home-manager-module-vm-testGenerated by
/doon Codex (modelgpt-5).