Unicode support in tags

[flyinggrizzly]

I have tried to add the following as a tag to a new note: #日本語/おかもと先生/宿題 (the slashes here are 'normal' slashes, input by changing back to my English input mode).

Instead of rendering out a link with the same content, it is rendering the following html:

<a href="z:tag/日本語/おかもと先生/宿題">z:tag/日本語/おかもと先生/宿題</a>

I have tried this with both hierarchical and flat tags, with the same issue.

If it matters, the tag was originally created using the iOS Japanese input keyboard, but I have since redone it on Ubuntu, and it hasn't worked in either case.

[srid]

Tag URIs are handled here:

neuron/neuron/src/lib/Neuron/Zettelkasten/Query/Parser.hs

Lines 102 to 105 in c7d2a3f

	-- Parse z:tag/foo
	(URI.unRText -> "tag") :| (nonEmpty . fmap (TagNode . URI.unRText) -> Just tagNodes)
	| noSlash -> do
	pure $ Some $ ZettelQuery_TagZettel (constructTag tagNodes)

and produced here:

neuron/neuron/src/lib/Neuron/Reader/Markdown.hs

Lines 148 to 152 in c7d2a3f

	pInlineTag = P.try $ do
	_ <- symbol '#'
	tag <- CM.untokenize <$> inlineTagP
	let tagQuery = "z:tag/" <> tag
	pure $! cmAutoLink tagQuery

I suppose a fix is to URI encode the tag in line 151. Any takers?

[flyinggrizzly]

Thank you for the fix! Tags are now working fine in Japanese.

It seems I may have missed a related issue though, since creating links from a tag query doesn't work with Unicode on the latest version of Neuron:

[[[z:zettels?tag=日本語/おかもと-先生/授業]]]

<a href="z:/%5bz%3azettels%3ftag=%e6%97%a5%e6%9c%ac%e8%aa%9e%2f%e3%81%8a%e3%81%8b%e3%82%82%e3%81%a8-%e5%85%88%e7%94%9f%2f%e6%8e%88%e6%a5%ad">z:/%5bz%3azettels%3ftag=%e6%97%a5%e6%9c%ac%e8%aa%9e%2f%e3%81%8a%e3%81%8b%e3%82%82%e3%81%a8-%e5%85%88%e7%94%9f%2f%e6%8e%88%e6%a5%ad</a>