Merged
Conversation
* Battery protection If your car battery voltage is lower than 0% switch off charging to stop the Eon from damaging the 12v car battery. Leaving you with a car that can not start but has a fully charged eon ;-) * add rbiasini comment && !ignition * Update Offroad_ChargeDisabled with voltage low * simplify alert * non-temporal hysteresis from @rbiasini And up the start charge limit to 12v. i.e. 50% car battery voltage * once battery power recovers to 11.500 volts charge This leaves 1v inbetween for any fluctuations that could occur. * fix indent * Fix indent of whole block It looks like sometimes when you copy and paste into the github web interface some white spacing gets added or removed. BE AWARE!
Aragon7777
referenced
this pull request
in Aragon7777/openpilot
Jun 21, 2021
* spacing ? tabs? which one is it lol * Update ui.hpp
Aragon7777
referenced
this pull request
in Aragon7777/openpilot
Oct 1, 2021
sshane
pushed a commit
that referenced
this pull request
Jan 17, 2023
Update interface.py for Bolt lateral and stop and go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If your car battery voltage is lower than 0% switch off charging to stop the Eon from damaging the 12v car battery. Leaving you with a car that can not start but has a fully charged eon ;-)
add rbiasini comment && !ignition
Update Offroad_ChargeDisabled with voltage low
simplify alert
non-temporal hysteresis from @rbiasini
And up the start charge limit to 12v. i.e. 50% car battery voltage
This leaves 1v inbetween for any fluctuations that could occur.
fix indent
Fix indent of whole block
It looks like sometimes when you copy and paste into the github web interface some white spacing gets added or removed. BE AWARE!
Choose one of the templates below:
Fingerprint
This pull requests adds a fingerprint for <Make - Model - Year - Trim>.
This is an explorer link to a drive with the stock system enabled: ...
Car support
This pull requests adds support for <Make - Model - Year - Trim>.
This is an explorer link to a drive with the stock system enabled: ...
This is an explorer link to a drive with openpilot system enabled: ...
Feature
This pull requests adds feature X
Description
Explain what the feature does
Testing
Explain how the feature was tested. Either by the added unit tests, or what tests were performed while driving.