This repository was archived by the owner on Dec 21, 2021. It is now read-only.
Test restart_after_ungraceful_shutdown_should_succeed added #24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lfrancke
previously approved these changes
May 19, 2021
soenkeliebau
previously approved these changes
May 20, 2021
Member
soenkeliebau
left a comment
soenkeliebau
left a comment
There was a problem hiding this comment.
LGTM overall, just left two questions
siegfriedweber
dismissed stale reviews from soenkeliebau and lfrancke
via
2b0800b
soenkeliebau
approved these changes
May 21, 2021
Member
soenkeliebau
left a comment
soenkeliebau
left a comment
There was a problem hiding this comment.
LGTM - all tests passed on the demo cluster from this morning as well
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests stackabletech/agent#164