This repository was archived by the owner on Dec 21, 2021. It is now read-only.
Test repository selection #43
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siegfriedweber
force-pushed
the
test_repositories
branch
from
1b226bf to
062ff2a
Compare
siegfriedweber
force-pushed
the
test_repositories
branch
from
062ff2a to
abf1dfb
Compare
maltesander
previously approved these changes
Jul 21, 2021
Member
maltesander
left a comment
maltesander
left a comment
There was a problem hiding this comment.
LGTM. Just one remark, you seem to mix curly and normal parenthesis on e.g. format! macro.
I do not see the difference in usage here, so i would keep it consistent? Or is it on purpose?
Member
Author
I unified the handling of multiline string literals. I changed all |
maltesander
approved these changes
Jul 21, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests stackabletech/agent#229
The agent-integration-tests now serve the repositories which are required for the test case. An asynchronous context is necessary which makes it impossible to use
TemporaryResourcebecause asynchronous Drop traits are not supported yet. Also the assertion framework cannot be used anymore because an assertion would panic if it is not met. This would skip the cleanup which would be done in the Drop trait.The ad-hoc repositories increase the convenience on the one hand but on the other hand they decrease it. Therefore the other test cases are not converted yet to these ad-hoc repositories. If the code proves useful after a while then it can be moved to the integration-test-commons.