This repository was archived by the owner on Dec 21, 2021. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 9
Volume mount package root hack for nifi #159
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
17c10c3
Render {{packageroot}} from the volume mount path in order to overwri…
maltesander 49d2263
Added comments.
maltesander 1dddfa6
Adapted to PR review.
maltesander 8d551cc
Merge remote-tracking branch 'origin/main' into volume_mount_package_…
maltesander 2209222
Now works with NiFi and other operators.
maltesander c5b6fd5
Merge branch 'main' into volume_mount_package_root_hack_for_nifi
maltesander 00dc277
Added test for config/package hack.
maltesander c1dad33
Added comment for test.
maltesander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we could make this a little bit less hacky by actually using the template renderer instead of string substitution here.
The current implementation would miss
{{ packageroot }}for example, which is still a valid Handlebars reference.Something along these lines should have a similar effect:
{{packageroot}}/tmp" should be rendered to for example "/opt/stackable/packages/kafka-2.6.0/tmp"
Since PathBuf::join() resolves absolute paths absolutely this would lead to
"/opt/stackable/servicedirectory".join("/opt/stackable/packages/kafka-2.6.0/tmp") -> "/opt/stackable/packages/kafka-2.6.0/tmp"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes thank you, that looks much better :)