Add Stacklet docs page #613
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for stackable-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
NickLarsenNZ
previously approved these changes
May 29, 2024
Member
NickLarsenNZ
left a comment
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Super nit-picky, so approving and leaving it up to you whether you accept some of the suggestions.
Some stuff I commented on was just reformatted from what was already there, so not necessary to change in this PR.
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Co-authored-by: Nick <NickLarsenNZ@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also replaces the roles and role groups page - it was the first page I wrote and very wordy, and it fits nicely into the Stacklet page, as a Stacklet is mostly made up of roles.
I then went into all the concept pages and adjusted some text to mention the Stacklet in more places, as well as adjusting formatting to our style guide.
closes #541. The new page mentions that naming conflicts can occur.