Replace FundError with InvoiceModal#455
Merged
huumn merged 1 commit intoAug 31, 2023
Merged
Conversation
Member
Author
|
I'll rebase this now since #432 was merged |
* invoices are no longer deleted to prevent double-spends but marked as confirmed. therefore, during checkInvoice, we also check if the invoice is already confirmed. * instead of showing FundError (with "fund wallet" and "pay invoice" as options), we now always immediately show an invoice * since flagging, paying bounties and poll voting used FundError but only allowed spending from balance, they now also support paying per invoice
ekzyis
force-pushed
the
405-combine-fund-wallet-and-pay-invoice
branch
from
367f183 to
6033f2d
Compare
Member
|
I'm not sure the info message actually scratches the issue's itch. It's just kind of telling people they can overpay an invoice which most wallets don't support and most people aren't aware of (not to mention there are limitations on how much you can overpay an invoice). So I suspect this message is more confusing than helpful. After seeing this invoicable stuff live for a bit, I don't think we need the ability to fund an account from these modals. It might not be worth the UX bloat to even do it how I imagined it and people can always put sats in their wallet if they want to. I'm going to remove the info message for now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
therefore, during checkInvoice, we also check if the invoice is already confirmed.
Based upon #432, so #432 should be merged first
Closes #405