Skip to content
This repository was archived by the owner on Dec 3, 2023. It is now read-only.

Fix ngRoute and others angular modules including #17

Closed
andrey-skl wants to merge 1 commit into from
Closed

Fix ngRoute and others angular modules including #17

andrey-skl wants to merge 1 commit into from

Conversation

@andrey-skl
Copy link

@andrey-skl andrey-skl commented Dec 3, 2014

As we can see, angular modules like angular-route declared in self avocation function:

(function(window, angular, undefined){
   angular.module('ngResource', ...
})(window, window.angular);

So plugin should support window.angular variable using too.

@andrey-skl andrey-skl mentioned this pull request Dec 3, 2014
Closed
stackfull added a commit that referenced this pull request Dec 7, 2014
@stackfull
Inject angular where window.angular is used.
bea1442 
This should work, but it does. It should make angular.js recurse but webpack takes care of it.
Many thanks to @huston007 for this even though I didn't merge #17.
@stackfull
Copy link
Owner

stackfull commented Dec 7, 2014

I used the core change here: bea1442

@stackfull stackfull closed this Dec 7, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@andrey-skl @stackfull