Stop changing permissions on files#1119
Merged
Merged
Conversation
These are causing changes to docker overlay filesystems with possible unintended consequences. It is also really slow to loop through so many files in ansible.
markgoddard
approved these changes
Jul 12, 2024
markgoddard
reviewed
Jul 12, 2024
Contributor
markgoddard
left a comment
markgoddard
left a comment
There was a problem hiding this comment.
Do we not need to do the same for RHEL?
markgoddard
reviewed
Jul 12, 2024
Contributor
markgoddard
left a comment
markgoddard
left a comment
There was a problem hiding this comment.
Should these group_vars be moved to the cis-hardening group?
Contributor
Author
Will do that in #1104 |
Contributor
Author
I believe I checked and couldn't see it doing the same kind of permission changes |
markgoddard
added a commit
that referenced
this pull request
Jul 22, 2024
A similar change was made for Ubuntu systems in #1119, but it did not apply to Rocky 9 systems. This changes brings the two into line.
markgoddard
pushed a commit
that referenced
this pull request
Jul 23, 2024
These are causing changes to docker overlay filesystems with possible unintended consequences. It is also really slow to loop through so many files in ansible. (cherry picked from commit 0d1dfe2)
This was referenced Jul 23, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These are causing changes to docker overlay filesystems with possible unintended consequences. It is also really slow to loop through so many files in ansible.