Further fixes to Prometheus blackbox exporter endpoints#1254
Merged
Alex-Welsh merged 4 commits intostackhpc/2023.1from Sep 10, 2024
Merged
Further fixes to Prometheus blackbox exporter endpoints#1254Alex-Welsh merged 4 commits intostackhpc/2023.1from
Alex-Welsh merged 4 commits intostackhpc/2023.1from
Conversation
Alex-Welsh
reviewed
Sep 2, 2024
Member
Alex-Welsh
left a comment
Alex-Welsh
left a comment
There was a problem hiding this comment.
It should be using the true jinja test rather than matching against the string, so I'd assume it would accept any truthy value. Evidently not
Alex-Welsh
previously approved these changes
Sep 2, 2024
markgoddard
reviewed
Sep 2, 2024
MoteHue
force-pushed
the
fix-kayobe-blackbox-endpoints
branch
from
c276cf5 to
52903dc
Compare
Alex-Welsh
reviewed
Sep 4, 2024
MoteHue
force-pushed
the
fix-kayobe-blackbox-endpoints
branch
from
52903dc to
1a3e80e
Compare
Alex-Welsh
reviewed
Sep 4, 2024
Member
Alex-Welsh
left a comment
Alex-Welsh
left a comment
There was a problem hiding this comment.
LGTM but I helped write it so someone else should approve
MoteHue
force-pushed
the
fix-kayobe-blackbox-endpoints
branch
from
1a3e80e to
61e6336
Compare
horizon_public_port is dependent on backend_tls being enabled, rather than external tls.
MoteHue
changed the title
Alex-Welsh
reviewed
Sep 5, 2024
Member
Alex-Welsh
left a comment
Alex-Welsh
left a comment
There was a problem hiding this comment.
Slight scope creep but I'll allow it. LGTM but someone else should approve
Contributor
Author
I've kept the changes in separate commits, so at least it will be distinct in the blame. |
markgoddard
reviewed
Sep 6, 2024
markgoddard
approved these changes
Sep 10, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Enabled items under prometheus_blackbox_exporter_endpoints_kayobe were not picked up because the attribute gets set to
enabled: 'True', rather the thanenabled: truethat the default values get. Likely a similar issue to this:ansible/ansible#11905 (comment)