zed: ci-multinode: Add Kolla Ansible TLS config to globals.yml#1255
Merged
Conversation
Previously we provided an additional file, globals-tls-config.yml, which would be appended to globals.yml at an appropriate point during multinode deployment. This could result in a merge conflict, which cannot be resolved by an automated process such as a GitHub Actions workflow. This change adds the TLS config to globals.yml conditionally, based on whether internal TLS is enabled. We are not removing globals-tls-config.yml for now, since it is used in the terraform-kayobe-multinode repo as a proxy for internal TLS support. The file has already been removed in the Antelope branch.
markgoddard
changed the title
It is a jinja template.
Contributor
Author
|
CI now passing. |
Alex-Welsh
approved these changes
Sep 4, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously we provided an additional file, globals-tls-config.yml, which
would be appended to globals.yml at an appropriate point during
multinode deployment. This could result in a merge conflict, which
cannot be resolved by an automated process such as a GitHub Actions
workflow.
This change adds the TLS config to globals.yml conditionally, based on
whether internal TLS is enabled.
We are not removing globals-tls-config.yml for now, since it is used in
the terraform-kayobe-multinode repo as a proxy for internal TLS support.
The file has already been removed in the Antelope branch.