Skip to content

growroot: Fix regex for md (sw-raid) cases#1279

Closed
mnasiadka wants to merge 1 commit intostackhpc/2024.1from
fix_growpart_md_2024.1
Closed

growroot: Fix regex for md (sw-raid) cases#1279
mnasiadka wants to merge 1 commit intostackhpc/2024.1from
fix_growpart_md_2024.1

Conversation

@mnasiadka
Copy link
Copy Markdown
Member

@mnasiadka mnasiadka commented Sep 11, 2024

No description provided.

@mnasiadka mnasiadka requested a review from a team as a code owner September 11, 2024 12:06
grzegorzkoper
grzegorzkoper approved these changes Sep 11, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@grzegorzkoper grzegorzkoper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM +1
Tested in SMSLAB

@markgoddard
Copy link
Copy Markdown
Contributor

markgoddard commented Sep 12, 2024

How does it relate to #818?

@mnasiadka
Copy link
Copy Markdown
Member Author

mnasiadka commented Sep 12, 2024

How does it relate to #818?

It doesn't, I haven't seen it - and given the endless thread in there and no resolution - maybe we can merge something that is not ideal but still helpful?

@markgoddard
Copy link
Copy Markdown
Contributor

markgoddard commented Sep 12, 2024

How does it relate to #818?

It doesn't, I haven't seen it - and given the endless thread in there and no resolution - maybe we can merge something that is not ideal but still helpful?

The issue is that there's scope for regression, and other related issues.

@mnasiadka
Copy link
Copy Markdown
Member Author

mnasiadka commented Sep 12, 2024

How does it relate to #818?

It doesn't, I haven't seen it - and given the endless thread in there and no resolution - maybe we can merge something that is not ideal but still helpful?

The issue is that there's scope for regression, and other related issues.

Let's go with #818, I tested it on all three possible disk names.

@mnasiadka mnasiadka closed this Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@grzegorzkoper grzegorzkoper grzegorzkoper approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@mnasiadka @markgoddard @grzegorzkoper