Various os_capacity fixes

[assumptionsandg]

• Various typo fixes.
• Renamed os_exporter to os_capacity.
• Renamed 70-oscapacity.yml.j2 to 70-oscapacity.yml to ensure correct templating.
• Added 70-oscapacity.yml to .yamlint ignore list.
• Conditional flag stackhpc_enable_os_capacity added to prevent HAProxy config and Prometheus scrape targets being copied in before manual deployment.
• Conditional flag stackhpc_os_capacity_openstack_verify added where certificate verification can be overridden.
• Fixed interval errors

[priteau]

Existing docs say:

StackHPC Kayobe Config includes this exporter by default

Should this be changed? Please also fix the typo: avaliable

[assumptionsandg]

Existing docs say:

StackHPC Kayobe Config includes this exporter by default

Should this be changed? Please also fix the typo: avaliable

I've made an update to the wording to show deployment needs to be triggered manually, hopefully that's better.

[Alex-Welsh]

LGTM

[assumptionsandg]

• Minor dashboard updates for graph intervals.
• Dashboard overhaul for OpenStack Project Metrics now including project and instance utilization

[priteau]

There is also a conflict caused by the rename of the HAProxy file: deployments which already have deployed os_exporter.cfg will get the following HAProxy error:

[ALERT]    (42) : Parsing [/etc/haproxy/services.d/os_capacity.cfg:2]: frontend 'os_capacity_frontend' has the same name as frontend 'os_capacity_frontend' declared at /etc/haproxy/services.d/os_exporter.cfg:2.
[ALERT]    (42) : Parsing [/etc/haproxy/services.d/os_capacity.cfg:11]: backend 'os_capacity_backend' has the same name as backend 'os_capacity_backend' declared at /etc/haproxy/services.d/os_exporter.cfg:11.
[ALERT]    (42) : Error(s) found in configuration file : /etc/haproxy/services.d/os_capacity.cfg

Operators need to be aware that they must delete /etc/kolla/haproxy/services.d/os_exporter.cfg first.

[mnasiadka]

There is also a conflict caused by the rename of the HAProxy file: deployments which already have deployed os_exporter.cfg will get the following HAProxy error:

[ALERT]    (42) : Parsing [/etc/haproxy/services.d/os_capacity.cfg:2]: frontend 'os_capacity_frontend' has the same name as frontend 'os_capacity_frontend' declared at /etc/haproxy/services.d/os_exporter.cfg:2.
[ALERT]    (42) : Parsing [/etc/haproxy/services.d/os_capacity.cfg:11]: backend 'os_capacity_backend' has the same name as backend 'os_capacity_backend' declared at /etc/haproxy/services.d/os_exporter.cfg:11.
[ALERT]    (42) : Error(s) found in configuration file : /etc/haproxy/services.d/os_capacity.cfg

Operators need to be aware that they must delete /etc/kolla/haproxy/services.d/os_exporter.cfg first.

I guess it would make sense to delete that in the deployment playbook

[priteau]

There is also a conflict caused by the rename of the HAProxy file: deployments which already have deployed os_exporter.cfg will get the following HAProxy error:

[ALERT]    (42) : Parsing [/etc/haproxy/services.d/os_capacity.cfg:2]: frontend 'os_capacity_frontend' has the same name as frontend 'os_capacity_frontend' declared at /etc/haproxy/services.d/os_exporter.cfg:2.
[ALERT]    (42) : Parsing [/etc/haproxy/services.d/os_capacity.cfg:11]: backend 'os_capacity_backend' has the same name as backend 'os_capacity_backend' declared at /etc/haproxy/services.d/os_exporter.cfg:11.
[ALERT]    (42) : Error(s) found in configuration file : /etc/haproxy/services.d/os_capacity.cfg

Operators need to be aware that they must delete /etc/kolla/haproxy/services.d/os_exporter.cfg first.

I guess it would make sense to delete that in the deployment playbook

Indeed. @assumptionsandg do you think you can make this change?

[priteau]

The "CPUs Used by Project" panel is reporting its values with MB unit.

[assumptionsandg]

The "CPUs Used by Project" panel is reporting its values with MB unit.

Changed unit type to none

[priteau]

I can't see it in the diff but I also spotted a typo Avaliable in the dashboard.

[markgoddard]

Let's get this thing in.